On Fri, Oct 24, 2025 at 02:15:44PM -0500, Alex Elder wrote:
> Change all the needs_*() functions so they are no longer inline, and return
> bool rather than int.
>
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/spi/spi-fsl-qspi.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
> index 1e27647dd2a09..1944e63169d36 100644
> --- a/drivers/spi/spi-fsl-qspi.c
> +++ b/drivers/spi/spi-fsl-qspi.c
> @@ -276,34 +276,34 @@ struct fsl_qspi {
> u32 memmap_phy;
> };
>
> -static inline int needs_swap_endian(struct fsl_qspi *q)
> +static bool needs_swap_endian(struct fsl_qspi *q)
> {
> - return q->devtype_data->quirks & QUADSPI_QUIRK_SWAP_ENDIAN;
> + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_SWAP_ENDIAN);
> }
>
> -static inline int needs_4x_clock(struct fsl_qspi *q)
> +static bool needs_4x_clock(struct fsl_qspi *q)
> {
> - return q->devtype_data->quirks & QUADSPI_QUIRK_4X_INT_CLK;
> + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_4X_INT_CLK);
> }
>
> -static inline int needs_fill_txfifo(struct fsl_qspi *q)
> +static bool needs_fill_txfifo(struct fsl_qspi *q)
> {
> - return q->devtype_data->quirks & QUADSPI_QUIRK_TKT253890;
> + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_TKT253890);
> }
>
> -static inline int needs_wakeup_wait_mode(struct fsl_qspi *q)
> +static bool needs_wakeup_wait_mode(struct fsl_qspi *q)
> {
> - return q->devtype_data->quirks & QUADSPI_QUIRK_TKT245618;
> + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_TKT245618);
> }
>
> -static inline int needs_amba_base_offset(struct fsl_qspi *q)
> +static bool needs_amba_base_offset(struct fsl_qspi *q)
> {
> return !(q->devtype_data->quirks & QUADSPI_QUIRK_BASE_INTERNAL);
> }
>
> -static inline int needs_tdh_setting(struct fsl_qspi *q)
> +static bool needs_tdh_setting(struct fsl_qspi *q)
> {
> - return q->devtype_data->quirks & QUADSPI_QUIRK_USE_TDH_SETTING;
> + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_USE_TDH_SETTING);
> }
>
> /*
> --
> 2.48.1
>