[v1] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

[PATCH] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Mykola Kvach 3 months, 2 weeks ago

The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V
rail for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
regulator-min/max-microvolt to 1800000. Correct both to 3300000
to match the rail name, the PCIe/M.2 power requirement, and the
actual hardware wiring on Orange Pi 5.

Signed-off-by: Mykola Kvach <xakep.amatop@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
index ad6d04793b0a..83b9b6645a1e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
@@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
 		gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
 		regulator-name = "vcc3v3_pcie20";
 		regulator-boot-on;
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
 		startup-delay-us = <50000>;
 		vin-supply = <&vcc5v0_sys>;
 	};
-- 
2.43.0

Re: [PATCH] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Michael Riesch 3 months, 1 week ago

Hi Mykola,

Thanks for your patch.

Cc: Muhammed who is the author of commit b6bc755d806e

On 10/24/25 19:38, Mykola Kvach wrote:
> The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V
> rail for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
> regulator-min/max-microvolt to 1800000. Correct both to 3300000
> to match the rail name, the PCIe/M.2 power requirement, and the
> actual hardware wiring on Orange Pi 5.
> 

I guess a "Fixes" tag is in order here:

Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")

And make sure to Cc: <stable@vger.kernel.org>

> Signed-off-by: Mykola Kvach <xakep.amatop@gmail.com>

The change itself makes sense to me.

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Best regards,
Michael

> ---
>  arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> index ad6d04793b0a..83b9b6645a1e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> @@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
>  		gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
>  		regulator-name = "vcc3v3_pcie20";
>  		regulator-boot-on;
> -		regulator-min-microvolt = <1800000>;
> -		regulator-max-microvolt = <1800000>;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
>  		startup-delay-us = <50000>;
>  		vin-supply = <&vcc5v0_sys>;
>  	};

Re: [PATCH] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Mykola Kvach 3 months ago

Hi Michael,

Thank you for the fast response and the review.

On Mon, Oct 27, 2025 at 2:39 PM Michael Riesch
<michael.riesch@collabora.com> wrote:
>
> Hi Mykola,
>
> Thanks for your patch.
>
> Cc: Muhammed who is the author of commit b6bc755d806e
>
> On 10/24/25 19:38, Mykola Kvach wrote:
> > The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V
> > rail for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
> > regulator-min/max-microvolt to 1800000. Correct both to 3300000
> > to match the rail name, the PCIe/M.2 power requirement, and the
> > actual hardware wiring on Orange Pi 5.
> >
>
> I guess a "Fixes" tag is in order here:
>
> Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")

Thank you for pointing that out. I will add the Fixes tag in v2.

>
> And make sure to Cc: <stable@vger.kernel.org>

Will do.

>
> > Signed-off-by: Mykola Kvach <xakep.amatop@gmail.com>
>
> The change itself makes sense to me.
>
> Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Thanks! I will carry your Reviewed-by in v2 (diff unchanged).


Best regards,
Mykola

>
> Best regards,
> Michael
>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> > index ad6d04793b0a..83b9b6645a1e 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> > @@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
> >               gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
> >               regulator-name = "vcc3v3_pcie20";
> >               regulator-boot-on;
> > -             regulator-min-microvolt = <1800000>;
> > -             regulator-max-microvolt = <1800000>;
> > +             regulator-min-microvolt = <3300000>;
> > +             regulator-max-microvolt = <3300000>;
> >               startup-delay-us = <50000>;
> >               vin-supply = <&vcc5v0_sys>;
> >       };
>

[PATCH v2] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Mykola Kvach 3 months ago

The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V rail
for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
regulator-min/max-microvolt to 1800000 (1.8 V). Correct both to 3300000
(3.3 V) to match the rail name, the PCIe/M.2 power requirement, and the
actual hardware wiring on Orange Pi 5.

Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")
Signed-off-by: Mykola Kvach <xakep.amatop@gmail.com>
Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
---
Changes in v2:
- add Fixes tag and Cc stable list as requested during review.
---
 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
index ad6d04793b0a..83b9b6645a1e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
@@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
 		gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
 		regulator-name = "vcc3v3_pcie20";
 		regulator-boot-on;
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
 		startup-delay-us = <50000>;
 		vin-supply = <&vcc5v0_sys>;
 	};
--
2.43.0

[PATCH v3] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Mykola Kvach 3 months ago

The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V rail
for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
regulator-min/max-microvolt to 1800000 (1.8 V). Correct both to 3300000
(3.3 V) to match the rail name, the PCIe/M.2 power requirement, and the
actual hardware wiring on Orange Pi 5.

Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")
Cc: stable@vger.kernel.org
Signed-off-by: Mykola Kvach <xakep.amatop@gmail.com>
Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
---
Changes in v3:
- add "Cc: stable@vger.kernel.org" to commit message.

Changes in v2:
- add Fixes tag and Cc stable list as requested during review.
---
 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
index ad6d04793b0a..83b9b6645a1e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
@@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
 		gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
 		regulator-name = "vcc3v3_pcie20";
 		regulator-boot-on;
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
 		startup-delay-us = <50000>;
 		vin-supply = <&vcc5v0_sys>;
 	};
--
2.43.0

Re: [PATCH v3] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Heiko Stuebner 2 months, 3 weeks ago

On Mon, 03 Nov 2025 12:27:40 +0200, Mykola Kvach wrote:
> The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V rail
> for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
> regulator-min/max-microvolt to 1800000 (1.8 V). Correct both to 3300000
> (3.3 V) to match the rail name, the PCIe/M.2 power requirement, and the
> actual hardware wiring on Orange Pi 5.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage
      commit: b5414520793e68d266fdd97a84989d9831156aad

Please start new threads when sending version x+1 and don't append
that new patch to the old thread (less confusing for tooling like b4).

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH v3] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

Posted by Mykola Kvach 2 months, 2 weeks ago

On Fri, Nov 14, 2025 at 1:18 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
>
> On Mon, 03 Nov 2025 12:27:40 +0200, Mykola Kvach wrote:
> > The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V rail
> > for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
> > regulator-min/max-microvolt to 1800000 (1.8 V). Correct both to 3300000
> > (3.3 V) to match the rail name, the PCIe/M.2 power requirement, and the
> > actual hardware wiring on Orange Pi 5.
> >
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage
>       commit: b5414520793e68d266fdd97a84989d9831156aad
>
> Please start new threads when sending version x+1 and don't append
> that new patch to the old thread (less confusing for tooling like b4).

Got it, thanks for the explanation.

>
> Best regards,
> --
> Heiko Stuebner <heiko@sntech.de>

Best regards,
Mykola