[v1] nfp: xsk: fix memory leak in nfp_net_alloc()

[PATCH net] nfp: xsk: fix memory leak in nfp_net_alloc()

Abdun Nihaal posted 1 patch 3 months, 2 weeks ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH net] nfp: xsk: fix memory leak in nfp_net_alloc()

Posted by Abdun Nihaal 3 months, 2 weeks ago

In nfp_net_alloc(), the memory allocated for xsk_pools is not freed in
the subsequent error paths, leading to a memory leak. Fix that by
freeing it in the error path.

Fixes: 6402528b7a0b ("nfp: xsk: add AF_XDP zero-copy Rx and Tx support")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
---
 drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 132626a3f9f7..f59466877be2 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -2566,6 +2566,7 @@ nfp_net_alloc(struct pci_dev *pdev, const struct nfp_dev_info *dev_info,
 	return nn;
 
 err_free_nn:
+	kfree(nn->dp.xsk_pools);
 	if (nn->dp.netdev)
 		free_netdev(nn->dp.netdev);
 	else
-- 
2.43.0

Re: [PATCH net] nfp: xsk: fix memory leak in nfp_net_alloc()

Posted by Jakub Kicinski 3 months, 2 weeks ago

On Fri, 24 Oct 2025 20:55:22 +0530 Abdun Nihaal wrote:
>  err_free_nn:
> +	kfree(nn->dp.xsk_pools);
>  	if (nn->dp.netdev)
>  		free_netdev(nn->dp.netdev);

Please add dedicated jump label for places which need to free xsk_pools
-- 
pw-bot: cr