From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
Enable USB support on SM8750 QRD variant. The current definition
will start the USB controller in peripheral mode by default until
dependencies are added, such as USB role detection.
Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
[Krishna: Flattened usb node QRD DTS]
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 13c7b9664c89..fc5d12bb41a5 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1054,3 +1054,25 @@ &ufs_mem_hc {
status = "okay";
};
+
+&usb_1 {
+ dr_mode = "peripheral";
+
+ status = "okay";
+};
+
+&usb_1_hsphy {
+ vdd-supply = <&vreg_l2d_0p88>;
+ vdda12-supply = <&vreg_l3g_1p2>;
+
+ phys = <&pmih0108_eusb2_repeater>;
+
+ status = "okay";
+};
+
+&usb_dp_qmpphy {
+ vdda-phy-supply = <&vreg_l3g_1p2>;
+ vdda-pll-supply = <&vreg_l2d_0p88>;
+
+ status = "okay";
+};
--
2.34.1On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>
> Enable USB support on SM8750 QRD variant. The current definition
> will start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
>
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Krishna: Flattened usb node QRD DTS]
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
NAK.
You ignored every previous tag - multiple reviews and tests, and then...
> ---
> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..fc5d12bb41a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>
> status = "okay";
> };
> +
> +&usb_1 {
> + dr_mode = "peripheral";
You sent something different with issues.
Really, this was a correct patch. Was reviewed. Why you decided to drop
all this, drop everything which was correct?
Your explanation:
"- Removed obtained RB tags since the code has changed significantly."
is just wrong. Almost NOTHING changed, except completely unimportant two
node merging.
NAK
Best regards,
Krzysztof
On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
> On 24/10/2025 17:15, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> Enable USB support on SM8750 QRD variant. The current definition
>> will start the USB controller in peripheral mode by default until
>> dependencies are added, such as USB role detection.
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Krishna: Flattened usb node QRD DTS]
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>
> NAK.
>
> You ignored every previous tag - multiple reviews and tests, and then...
>
>> ---
>> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> index 13c7b9664c89..fc5d12bb41a5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>
>> status = "okay";
>> };
>> +
>> +&usb_1 {
>> + dr_mode = "peripheral";
>
> You sent something different with issues.
>
> Really, this was a correct patch. Was reviewed. Why you decided to drop
> all this, drop everything which was correct?
>
> Your explanation:
> "- Removed obtained RB tags since the code has changed significantly."
> is just wrong. Almost NOTHING changed, except completely unimportant two
> node merging.
>
> NAK
>
Apologies Krzysztof,
On first patch that adds changes to base DTSI, there were changes moving
to newer bindings and merging child node and parent node. I should've
removed RB tags received on that patch only. But I was over cautious and
misinterpreted the rules and removed them on the other patches as well.
Will be careful the next time.
Also is there any issue with marking dr_mode as peripheral here in usb_1
node ?
Regards,
Krishna,
On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
>
>
> On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
>> On 24/10/2025 17:15, Krishna Kurapati wrote:
>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>
>>> Enable USB support on SM8750 QRD variant. The current definition
>>> will start the USB controller in peripheral mode by default until
>>> dependencies are added, such as USB role detection.
>>>
>>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>> [Krishna: Flattened usb node QRD DTS]
>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>
>> NAK.
>>
>> You ignored every previous tag - multiple reviews and tests, and then...
>>
>>> ---
>>> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>> 1 file changed, 22 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>> index 13c7b9664c89..fc5d12bb41a5 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>>
>>> status = "okay";
>>> };
>>> +
>>> +&usb_1 {
>>> + dr_mode = "peripheral";
>>
>> You sent something different with issues.
>>
>> Really, this was a correct patch. Was reviewed. Why you decided to drop
>> all this, drop everything which was correct?
>>
>> Your explanation:
>> "- Removed obtained RB tags since the code has changed significantly."
>> is just wrong. Almost NOTHING changed, except completely unimportant two
>> node merging.
>>
>> NAK
>>
>
>
> Apologies Krzysztof,
>
> On first patch that adds changes to base DTSI, there were changes moving
> to newer bindings and merging child node and parent node. I should've
> removed RB tags received on that patch only. But I was over cautious and
> misinterpreted the rules and removed them on the other patches as well.
> Will be careful the next time.
>
> Also is there any issue with marking dr_mode as peripheral here in usb_1
> node ?
No, I think I looked at your other patch. Tthis was reviewed at v4 and
v5, which then it was changed breaking sorting order. This one looks
correct.
Best regards,
Krzysztof
On 10/29/2025 5:35 PM, Krzysztof Kozlowski wrote:
> On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
>>> On 24/10/2025 17:15, Krishna Kurapati wrote:
>>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>
>>>> Enable USB support on SM8750 QRD variant. The current definition
>>>> will start the USB controller in peripheral mode by default until
>>>> dependencies are added, such as USB role detection.
>>>>
>>>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>> [Krishna: Flattened usb node QRD DTS]
>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>
>>> NAK.
>>>
>>> You ignored every previous tag - multiple reviews and tests, and then...
>>>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>>> 1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>> index 13c7b9664c89..fc5d12bb41a5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>>>
>>>> status = "okay";
>>>> };
>>>> +
>>>> +&usb_1 {
>>>> + dr_mode = "peripheral";
>>>
>>> You sent something different with issues.
>>>
>>> Really, this was a correct patch. Was reviewed. Why you decided to drop
>>> all this, drop everything which was correct?
>>>
>>> Your explanation:
>>> "- Removed obtained RB tags since the code has changed significantly."
>>> is just wrong. Almost NOTHING changed, except completely unimportant two
>>> node merging.
>>>
>>> NAK
>>>
>>
>>
>> Apologies Krzysztof,
>>
>> On first patch that adds changes to base DTSI, there were changes moving
>> to newer bindings and merging child node and parent node. I should've
>> removed RB tags received on that patch only. But I was over cautious and
>> misinterpreted the rules and removed them on the other patches as well.
>> Will be careful the next time.
>>
>> Also is there any issue with marking dr_mode as peripheral here in usb_1
>> node ?
>
> No, I think I looked at your other patch. Tthis was reviewed at v4 and
> v5, which then it was changed breaking sorting order. This one looks
> correct.
>
Ok.
I will send v10 tomorrow. Can I add yours and Dmitry's RB tag on the MTP
and QRD patches and then send it ? I will implement feedback from Dmitry
on SOC dtsi patch in v10.
Regards,
Krishna,
On Wed, Oct 29, 2025 at 06:00:02PM +0530, Krishna Kurapati PSSNV wrote:
>
>
> On 10/29/2025 5:35 PM, Krzysztof Kozlowski wrote:
> > On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
> > >
> > >
> > > On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
> > > > On 24/10/2025 17:15, Krishna Kurapati wrote:
> > > > > From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > > >
> > > > > Enable USB support on SM8750 QRD variant. The current definition
> > > > > will start the USB controller in peripheral mode by default until
> > > > > dependencies are added, such as USB role detection.
> > > > >
> > > > > Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > > > [Krishna: Flattened usb node QRD DTS]
> > > > > Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > > >
> > > > NAK.
> > > >
> > > > You ignored every previous tag - multiple reviews and tests, and then...
> > > >
> > > > > ---
> > > > > arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
> > > > > 1 file changed, 22 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> > > > > index 13c7b9664c89..fc5d12bb41a5 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> > > > > +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> > > > > @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
> > > > > status = "okay";
> > > > > };
> > > > > +
> > > > > +&usb_1 {
> > > > > + dr_mode = "peripheral";
> > > >
> > > > You sent something different with issues.
> > > >
> > > > Really, this was a correct patch. Was reviewed. Why you decided to drop
> > > > all this, drop everything which was correct?
> > > >
> > > > Your explanation:
> > > > "- Removed obtained RB tags since the code has changed significantly."
> > > > is just wrong. Almost NOTHING changed, except completely unimportant two
> > > > node merging.
> > > >
> > > > NAK
> > > >
> > >
> > >
> > > Apologies Krzysztof,
> > >
> > > On first patch that adds changes to base DTSI, there were changes moving
> > > to newer bindings and merging child node and parent node. I should've
> > > removed RB tags received on that patch only. But I was over cautious and
> > > misinterpreted the rules and removed them on the other patches as well.
> > > Will be careful the next time.
> > >
> > > Also is there any issue with marking dr_mode as peripheral here in usb_1
> > > node ?
> >
> > No, I think I looked at your other patch. Tthis was reviewed at v4 and
> > v5, which then it was changed breaking sorting order. This one looks
> > correct.
> >
>
> Ok.
>
> I will send v10 tomorrow. Can I add yours and Dmitry's RB tag on the MTP and
> QRD patches and then send it ? I will implement feedback from Dmitry on SOC
> dtsi patch in v10.
Could you please answer the questions that I asked for this series?
Also, why is there no link to v8 in your cover letter?
--
With best wishes
Dmitry
On 10/29/2025 6:36 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 29, 2025 at 06:00:02PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/29/2025 5:35 PM, Krzysztof Kozlowski wrote:
>>> On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
>>>>
>>>>
>>>> On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
>>>>> On 24/10/2025 17:15, Krishna Kurapati wrote:
>>>>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>>>
>>>>>> Enable USB support on SM8750 QRD variant. The current definition
>>>>>> will start the USB controller in peripheral mode by default until
>>>>>> dependencies are added, such as USB role detection.
>>>>>>
>>>>>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>>> [Krishna: Flattened usb node QRD DTS]
>>>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>>>
>>>>> NAK.
>>>>>
>>>>> You ignored every previous tag - multiple reviews and tests, and then...
>>>>>
>>>>>> ---
>>>>>> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>>>>> 1 file changed, 22 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>>>> index 13c7b9664c89..fc5d12bb41a5 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>>>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>>>>> status = "okay";
>>>>>> };
>>>>>> +
>>>>>> +&usb_1 {
>>>>>> + dr_mode = "peripheral";
>>>>>
>>>>> You sent something different with issues.
>>>>>
>>>>> Really, this was a correct patch. Was reviewed. Why you decided to drop
>>>>> all this, drop everything which was correct?
>>>>>
>>>>> Your explanation:
>>>>> "- Removed obtained RB tags since the code has changed significantly."
>>>>> is just wrong. Almost NOTHING changed, except completely unimportant two
>>>>> node merging.
>>>>>
>>>>> NAK
>>>>>
>>>>
>>>>
>>>> Apologies Krzysztof,
>>>>
>>>> On first patch that adds changes to base DTSI, there were changes moving
>>>> to newer bindings and merging child node and parent node. I should've
>>>> removed RB tags received on that patch only. But I was over cautious and
>>>> misinterpreted the rules and removed them on the other patches as well.
>>>> Will be careful the next time.
>>>>
>>>> Also is there any issue with marking dr_mode as peripheral here in usb_1
>>>> node ?
>>>
>>> No, I think I looked at your other patch. Tthis was reviewed at v4 and
>>> v5, which then it was changed breaking sorting order. This one looks
>>> correct.
>>>
>>
>> Ok.
>>
>> I will send v10 tomorrow. Can I add yours and Dmitry's RB tag on the MTP and
>> QRD patches and then send it ? I will implement feedback from Dmitry on SOC
>> dtsi patch in v10.
>
> Could you please answer the questions that I asked for this series?
>
Replied to the questions and will update in v10, mentioned dependencies.
Also will add qmp pipe clock in gcc properties.
> Also, why is there no link to v8 in your cover letter?
>
My bad. Missed adding it.
Will fix it up in next version.
Regards,
Krishna,
On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>
> Enable USB support on SM8750 QRD variant. The current definition
> will start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
>
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Krishna: Flattened usb node QRD DTS]
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..fc5d12bb41a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>
> status = "okay";
> };
> +
> +&usb_1 {
Still wrongly ordered. Please follow DTS coding style.
Best regards,
Krzysztof
On 29/10/2025 09:02, Krzysztof Kozlowski wrote:
> On 24/10/2025 17:15, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> Enable USB support on SM8750 QRD variant. The current definition
>> will start the USB controller in peripheral mode by default until
>> dependencies are added, such as USB role detection.
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Krishna: Flattened usb node QRD DTS]
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> index 13c7b9664c89..fc5d12bb41a5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>
>> status = "okay";
>> };
>> +
>> +&usb_1 {
>
> Still wrongly ordered. Please follow DTS coding style.
My bad, this is actually correctly ordered, your previous patches were
incorrect. Nothing in the changelog explained that, though.
Best regards,
Krzysztof
© 2016 - 2026 Red Hat, Inc.