1. Patchew
  2. linux
  3. [PATCH v9 0/3] Introduce USB DT support for SM8750
  4. View patch

[PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

Krishna Kurapati posted 3 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Krishna Kurapati 3 months, 2 weeks ago 
From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>

Enable USB support on SM8750 MTP variants.  The current definition will
start the USB controller in peripheral mode by default until
dependencies are added, such as USB role detection.

Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
[Konrad: Provided diff to flatten USB node on MTP]
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 3bbb53b7c71f..1b526d96fba8 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1200,3 +1200,25 @@ &ufs_mem_hc {
 
 	status = "okay";
 };
+
+&usb_1 {
+	dr_mode = "peripheral";
+
+	status = "okay";
+};
+
+&usb_1_hsphy {
+	vdd-supply = <&vreg_l2d_0p88>;
+	vdda12-supply = <&vreg_l3g_1p2>;
+
+	phys = <&pmih0108_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_dp_qmpphy {
+	vdda-phy-supply = <&vreg_l3g_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p88>;
+
+	status = "okay";
+};
-- 
2.34.1
Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Krzysztof Kozlowski 3 months, 1 week ago 
On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> Enable USB support on SM8750 MTP variants.  The current definition will
> start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Konrad: Provided diff to flatten USB node on MTP]
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 3bbb53b7c71f..1b526d96fba8 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> @@ -1200,3 +1200,25 @@ &ufs_mem_hc {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {


Still wrongly ordered. Please follow DTS coding style.

Best regards,
Krzysztof
Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Dmitry Baryshkov 3 months, 1 week ago 
On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> Enable USB support on SM8750 MTP variants.  The current definition will
> start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.

Which dependencies?

> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Konrad: Provided diff to flatten USB node on MTP]
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 

-- 
With best wishes
Dmitry
Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Krishna Kurapati PSSNV 3 months, 1 week ago 

On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
> On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> Enable USB support on SM8750 MTP variants.  The current definition will
>> start the USB controller in peripheral mode by default until
>> dependencies are added, such as USB role detection.
> 
> Which dependencies?
> 

Dependencies like pmic-glink and adding remote endpoints for otg 
support. Till they are added, we can enable peripheral mode.

Regards,
Krishna,

>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Konrad: Provided diff to flatten USB node on MTP]
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>
Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Bjorn Andersson 3 months, 1 week ago 
On Wed, Oct 29, 2025 at 09:20:48PM +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
> > On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
> > > From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > 
> > > Enable USB support on SM8750 MTP variants.  The current definition will
> > > start the USB controller in peripheral mode by default until
> > > dependencies are added, such as USB role detection.
> > 
> > Which dependencies?
> > 
> 
> Dependencies like pmic-glink and adding remote endpoints for otg support.
> Till they are added, we can enable peripheral mode.
> 

But this is 8750, Jishnu got qcom,sm8750-pmic-glink landed in the
binding 9 months ago, so why are we spending time discussing this?

Why not just add the whole shebang at once?

Regards,
Bjorn

> Regards,
> Krishna,
> 
> > > 
> > > Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > [Konrad: Provided diff to flatten USB node on MTP]
> > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
> > >   1 file changed, 22 insertions(+)
> > > 
> > 
>
Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Krishna Kurapati PSSNV 3 months, 1 week ago 

On 10/29/2025 10:04 PM, Bjorn Andersson wrote:
> On Wed, Oct 29, 2025 at 09:20:48PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
>>> On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
>>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>
>>>> Enable USB support on SM8750 MTP variants.  The current definition will
>>>> start the USB controller in peripheral mode by default until
>>>> dependencies are added, such as USB role detection.
>>>
>>> Which dependencies?
>>>
>>
>> Dependencies like pmic-glink and adding remote endpoints for otg support.
>> Till they are added, we can enable peripheral mode.
>>
> 
> But this is 8750, Jishnu got qcom,sm8750-pmic-glink landed in the
> binding 9 months ago, so why are we spending time discussing this?
> 
> Why not just add the whole shebang at once?
> 

Initially I didn't add those changes because the series already had 
acked patches and I didn't want to disturb them. I can add them in next 
submission and send them out.

Regards,
Krishna,
Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
Posted by Bjorn Andersson 3 months, 1 week ago 
On Wed, Oct 29, 2025 at 10:12:59PM +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/29/2025 10:04 PM, Bjorn Andersson wrote:
> > On Wed, Oct 29, 2025 at 09:20:48PM +0530, Krishna Kurapati PSSNV wrote:
> > > 
> > > 
> > > On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
> > > > On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
> > > > > From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > > > 
> > > > > Enable USB support on SM8750 MTP variants.  The current definition will
> > > > > start the USB controller in peripheral mode by default until
> > > > > dependencies are added, such as USB role detection.
> > > > 
> > > > Which dependencies?
> > > > 
> > > 
> > > Dependencies like pmic-glink and adding remote endpoints for otg support.
> > > Till they are added, we can enable peripheral mode.
> > > 
> > 
> > But this is 8750, Jishnu got qcom,sm8750-pmic-glink landed in the
> > binding 9 months ago, so why are we spending time discussing this?
> > 
> > Why not just add the whole shebang at once?
> > 
> 
> Initially I didn't add those changes because the series already had acked
> patches and I didn't want to disturb them. I can add them in next submission
> and send them out.
> 

Now that you don't carry them anymore - and you have to resubmit this
anyways - I'd prefer that you just enable the whole thing over trying to
make up a reason suitable for encoding in the git log...

Regards,
Bjorn

> Regards,
> Krishna,

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.