[v3] nstree: listns()

[PATCH v3 05/70] nsfs: raise SB_I_NODEV and SB_I_NOEXEC

Posted by Christian Brauner 3 months, 2 weeks ago

There's zero need for nsfs to allow device nodes or execution.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 fs/nsfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/nsfs.c b/fs/nsfs.c
index 0e3fe8fda5bf..363be226e357 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -589,6 +589,8 @@ static int nsfs_init_fs_context(struct fs_context *fc)
 	struct pseudo_fs_context *ctx = init_pseudo(fc, NSFS_MAGIC);
 	if (!ctx)
 		return -ENOMEM;
+	fc->s_iflags |= SB_I_NOEXEC;
+	fc->s_iflags |= SB_I_NODEV;
 	ctx->s_d_flags |= DCACHE_DONTCACHE;
 	ctx->ops = &nsfs_ops;
 	ctx->eops = &nsfs_export_operations;

-- 
2.47.3

Re: [PATCH v3 05/70] nsfs: raise SB_I_NODEV and SB_I_NOEXEC

Posted by Jeff Layton 3 months, 2 weeks ago

On Fri, 2025-10-24 at 12:52 +0200, Christian Brauner wrote:
> There's zero need for nsfs to allow device nodes or execution.
> 
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> ---
>  fs/nsfs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nsfs.c b/fs/nsfs.c
> index 0e3fe8fda5bf..363be226e357 100644
> --- a/fs/nsfs.c
> +++ b/fs/nsfs.c
> @@ -589,6 +589,8 @@ static int nsfs_init_fs_context(struct fs_context *fc)
>  	struct pseudo_fs_context *ctx = init_pseudo(fc, NSFS_MAGIC);
>  	if (!ctx)
>  		return -ENOMEM;
> +	fc->s_iflags |= SB_I_NOEXEC;
> +	fc->s_iflags |= SB_I_NODEV;

nit: why not do this in one?

	fc->s_iflags |= SB_I_NOEXEC | SB_I_NODEV;

>  	ctx->s_d_flags |= DCACHE_DONTCACHE;
>  	ctx->ops = &nsfs_ops;
>  	ctx->eops = &nsfs_export_operations;

-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH v3 05/70] nsfs: raise SB_I_NODEV and SB_I_NOEXEC

Posted by Christian Brauner 3 months, 1 week ago

On Mon, Oct 27, 2025 at 09:13:21AM -0400, Jeff Layton wrote:
> On Fri, 2025-10-24 at 12:52 +0200, Christian Brauner wrote:
> > There's zero need for nsfs to allow device nodes or execution.
> > 
> > Signed-off-by: Christian Brauner <brauner@kernel.org>
> > ---
> >  fs/nsfs.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/fs/nsfs.c b/fs/nsfs.c
> > index 0e3fe8fda5bf..363be226e357 100644
> > --- a/fs/nsfs.c
> > +++ b/fs/nsfs.c
> > @@ -589,6 +589,8 @@ static int nsfs_init_fs_context(struct fs_context *fc)
> >  	struct pseudo_fs_context *ctx = init_pseudo(fc, NSFS_MAGIC);
> >  	if (!ctx)
> >  		return -ENOMEM;
> > +	fc->s_iflags |= SB_I_NOEXEC;
> > +	fc->s_iflags |= SB_I_NODEV;
> 
> nit: why not do this in one?
> 
> 	fc->s_iflags |= SB_I_NOEXEC | SB_I_NODEV;

done.