[PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add generic dwxgmac compatible

Steffen Trumtrar posted 10 patches 3 months, 2 weeks ago
[PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add generic dwxgmac compatible
Posted by Steffen Trumtrar 3 months, 2 weeks ago
Add the more generic "snps,dwxgmac" compatible to the list of
compatibles for the agilex5.

The snps,dwmac binding explicitly uses the "snps,dwxgmac-2.10",
"snps,dwxgmac" combination as example; the stmmac driver only checks on
dwmac and dwxgmac compatibles to decide what kind of gmac it is working
with.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index fc445ad5a1f1a..b53847a2d9536 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -46,6 +46,7 @@ properties:
       - items:
           - const: altr,socfpga-stmmac-agilex5
           - const: snps,dwxgmac-2.10
+          - const: snps,dwxgmac
 
   clocks:
     minItems: 1

-- 
2.51.0
Re: [PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add generic dwxgmac compatible
Posted by Krzysztof Kozlowski 3 months, 2 weeks ago
On 24/10/2025 13:49, Steffen Trumtrar wrote:
> Add the more generic "snps,dwxgmac" compatible to the list of
> compatibles for the agilex5.
> 
> The snps,dwmac binding explicitly uses the "snps,dwxgmac-2.10",

Hm? No, binding says only dwxgmac-2.10, DTS only dwxgmac-2.10.

> "snps,dwxgmac" combination as example; the stmmac driver only checks on

Example does not matter.

> dwmac and dwxgmac compatibles to decide what kind of gmac it is working

Huh? I clearly see snps,dwxgmac-2.10 in dwmac-generic.c

> with.
This change really lacks proper rationale.

Best regards,
Krzysztof