[v3] ptp/ptp_vmw: enhancements to ptp_vmw

[PATCH v3 0/2] ptp/ptp_vmw: enhancements to ptp_vmw

Posted by Ajay Kaher 1 month, 3 weeks ago

This series provides:

- implementation of PTP clock adjustments ops for ptp_vmw driver to
adjust its time and frequency, allowing time transfer from a virtual
machine to the underlying hypervisor.

- add a module parameter probe_hv_port that allows ptp_vmw driver to
be loaded even when ACPI is disabled, by directly probing for the
device using VMware hypervisor port commands.

v3:
- [PATCH 1/2]: reverting back the changes of ptp_vmw_pclk_read()
- [PATCH 2/2]: calling ptp_vmw_pclk_read() without cmd

v2:
- [PATCH 2/2]: remove blank line in ptp_vmw_init()

v2 link:
https://lore.kernel.org/lkml/20251022105128.3679902-1-ajay.kaher@broadcom.com/

v1 link:
https://lore.kernel.org/lkml/20250821110323.974367-1-ajay.kaher@broadcom.com/

Ajay Kaher (2):
  ptp/ptp_vmw: Implement PTP clock adjustments ops
  ptp/ptp_vmw: load ptp_vmw driver by directly probing the device

 drivers/ptp/ptp_vmw.c | 99 +++++++++++++++++++++++++++++++++++--------
 1 file changed, 82 insertions(+), 17 deletions(-)

-- 
2.40.4

Re: [PATCH v3 0/2] ptp/ptp_vmw: enhancements to ptp_vmw

Posted by Jakub Kicinski 1 month, 2 weeks ago

On Thu, 23 Oct 2025 13:10:46 +0000 Ajay Kaher wrote:
> This series provides:
> 
> - implementation of PTP clock adjustments ops for ptp_vmw driver to
> adjust its time and frequency, allowing time transfer from a virtual
> machine to the underlying hypervisor.
> 
> - add a module parameter probe_hv_port that allows ptp_vmw driver to
> be loaded even when ACPI is disabled, by directly probing for the
> device using VMware hypervisor port commands.

We'd like to get out of the business of representing pure VM clocks
as PTP devices, see:
https://lore.kernel.org/20250815113814.5e135318@kernel.org

Your driver is already in the tree which is a bit awkward but I'd
prefer to resolve that discussion before we add any more functionality
to such clocks.
-- 
pw-bot: cr

Re: [PATCH v3 0/2] ptp/ptp_vmw: enhancements to ptp_vmw

Posted by Vadim Fedorenko 1 month, 3 weeks ago

On 23/10/2025 14:10, Ajay Kaher wrote:
> This series provides:
> 
> - implementation of PTP clock adjustments ops for ptp_vmw driver to
> adjust its time and frequency, allowing time transfer from a virtual
> machine to the underlying hypervisor.
> 
> - add a module parameter probe_hv_port that allows ptp_vmw driver to
> be loaded even when ACPI is disabled, by directly probing for the
> device using VMware hypervisor port commands.
> 
> v3:
> - [PATCH 1/2]: reverting back the changes of ptp_vmw_pclk_read()
> - [PATCH 2/2]: calling ptp_vmw_pclk_read() without cmd
> 
> v2:
> - [PATCH 2/2]: remove blank line in ptp_vmw_init()
> 
> v2 link:
> https://lore.kernel.org/lkml/20251022105128.3679902-1-ajay.kaher@broadcom.com/
> 
> v1 link:
> https://lore.kernel.org/lkml/20250821110323.974367-1-ajay.kaher@broadcom.com/
> 
> Ajay Kaher (2):
>    ptp/ptp_vmw: Implement PTP clock adjustments ops
>    ptp/ptp_vmw: load ptp_vmw driver by directly probing the device
> 
>   drivers/ptp/ptp_vmw.c | 99 +++++++++++++++++++++++++++++++++++--------
>   1 file changed, 82 insertions(+), 17 deletions(-)
> 

For the series:
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>