Require spaces around '=' and '<'. Add spaces around binary operators.
Enforce error fixing based on checkpatch.pl output on file.
Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
improves usage of ret variable.

Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
Suggested-by: Andi Shyti <andi.shyti@kernel.org>
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
 drivers/i2c/algos/i2c-algo-pcf.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c
index 41a81d37e880..06b9fd355bff 100644
--- a/drivers/i2c/algos/i2c-algo-pcf.c
+++ b/drivers/i2c/algos/i2c-algo-pcf.c
@@ -183,7 +183,7 @@ static int pcf_sendbytes(struct i2c_adapter *i2c_adap, const char *buf,
 	struct i2c_algo_pcf_data *adap = i2c_adap->algo_data;
 	int wrcount, status, timeout;

-	for (wrcount=0; wrcount<count; ++wrcount) {
+	for (wrcount = 0; wrcount < count; ++wrcount) {
 		i2c_outb(adap, buf[wrcount]);
 		timeout = wait_for_pin(adap, &status);
 		if (timeout) {
@@ -272,7 +272,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
 	struct i2c_algo_pcf_data *adap = i2c_adap->algo_data;
 	struct i2c_msg *pmsg;
 	int i;
-	int ret=0, timeout, status;
+	int timeout, status;

 	if (adap->xfer_begin)
 		adap->xfer_begin(adap->data);
@@ -284,9 +284,10 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
 		goto out;
 	}

-	for (i = 0;ret >= 0 && i < num; i++) {
-		pmsg = &msgs[i];
+	for (i = 0; i < num; i++) {
+		int ret;

+		pmsg = &msgs[i];
 		ret = pcf_doAddress(adap, pmsg);

 		/* Send START */
@@ -321,6 +322,9 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
 			ret = pcf_sendbytes(i2c_adap, pmsg->buf, pmsg->len,
 					    (i + 1 == num));
 		}
+
+		if (ret < 0)
+			goto out;
 	}

 out:
--
2.43.0

Hi Cezar,

On Thu, Oct 23, 2025 at 03:00:41PM +0300, Cezar Chiru wrote:
> Require spaces around '=' and '<'. Add spaces around binary operators.
> Enforce error fixing based on checkpatch.pl output on file.
> Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> improves usage of ret variable.
> 
> Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
> Suggested-by: Andi Shyti <andi.shyti@kernel.org>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>

you don't really need to resend patches for updating the tag
list. Anyway, that's OK, better to send than not to send, when in
doubt, ask.

For this patch I think neither me or Andy have been suggesting
the change. The change came from you, we made observation which
you applied, this is the normal review process.

If you don't mind, I'm going to remove them when applying (let me
know if you don't agree). No need to resend.

Andi

Hi Andi,

> > Require spaces around '=' and '<'. Add spaces around binary operators.
> > Enforce error fixing based on checkpatch.pl output on file.
> > Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> > improves usage of ret variable.
> >
> > Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
> > Suggested-by: Andi Shyti <andi.shyti@kernel.org>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> you don't really need to resend patches for updating the tag
> list. Anyway, that's OK, better to send than not to send, when in
> doubt, ask.

Anyways I had to resend as I grouped 3 patches into 1 patch series

> For this patch I think neither me or Andy have been suggesting
> the change. The change came from you, we made observation which
> you applied, this is the normal review process.

Can you please let me know the process of tagging with Suggested-by
without resending the patch. I don't know how people add reviewed-by
or ACK-ed-by or Suggested-by other than resend the patch?
I've seen it but have yet to figure how to do it.

> If you don't mind, I'm going to remove them when applying (let me
> know if you don't agree). No need to resend.

OK. Do as you want and think it's right.

Regards,
Cezar Chiru

Hi Cezar,

On Fri, Oct 24, 2025 at 04:55:28PM +0300, Cezar Chiru wrote:
> > > Require spaces around '=' and '<'. Add spaces around binary operators.
> > > Enforce error fixing based on checkpatch.pl output on file.
> > > Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> > > improves usage of ret variable.
> > >
> > > Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
> > > Suggested-by: Andi Shyti <andi.shyti@kernel.org>
> > > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> >
> > you don't really need to resend patches for updating the tag
> > list. Anyway, that's OK, better to send than not to send, when in
> > doubt, ask.
> 
> Anyways I had to resend as I grouped 3 patches into 1 patch series
> 
> > For this patch I think neither me or Andy have been suggesting
> > the change. The change came from you, we made observation which
> > you applied, this is the normal review process.
> 
> Can you please let me know the process of tagging with Suggested-by
> without resending the patch. I don't know how people add reviewed-by
> or ACK-ed-by or Suggested-by other than resend the patch?
> I've seen it but have yet to figure how to do it.

with Reviewed-by I understand that you have carefully reviewed
the code line by line, agree with everything written, and do not
see any issues or major improvements to be made.

With Acked-by I understand that you have read the change and
agree with it, but you may not have gone into the fine details.
You are simply OK with the patch being applied.

With Suggested-by I understand that someone has proposed the
entire idea behind the patch, not just smaller improvements or
changes made during review. For example, if I tell you that 'ret'
does not need to be initialised and can be moved inside the for
loop, that comes from review. However, if I suggest sending a new
patch changing the function type, that would justify a
Suggested-by tag.

Then there are other tags, such as Reported-by when someone
reports an issue, and many more that you will learn if you stay
in the community (and I hope you will).

Everything is more or less documented in
Documentation/process/submitting-patches.rst, and when in doubt,
asking is always the right thing to do.

Again, thank you for your patches,
Andi

On Thu, Oct 23, 2025 at 03:00:41PM +0300, Cezar Chiru wrote:
> Require spaces around '=' and '<'. Add spaces around binary operators.
> Enforce error fixing based on checkpatch.pl output on file.
> Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> improves usage of ret variable.

...

> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>

I haven't suggested much, but if you insist in the tag I won't object.

-- 
With Best Regards,
Andy Shevchenko