pinctrl: realtek: Select REGMAP_MMIO for RTD driver

[PATCH] pinctrl: realtek: Select REGMAP_MMIO for RTD driver

Posted by Yu-Chun Lin 3 months, 2 weeks ago

The pinctrl-rtd driver uses 'devm_regmap_init_mmio', which requires
'REGMAP_MMIO' to be enabled.

Without this selection, the build fails with an undefined reference:
aarch64-none-linux-gnu-ld: drivers/pinctrl/realtek/pinctrl-rtd.o: in
function rtd_pinctrl_probe': pinctrl-rtd.c:(.text+0x5a0): undefined
reference to __devm_regmap_init_mmio_clk'

Fix this by selecting 'REGMAP_MMIO' in the Kconfig.

Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
---
 drivers/pinctrl/realtek/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/realtek/Kconfig b/drivers/pinctrl/realtek/Kconfig
index 0fc6bd4fcb7e..400c9e5b16ad 100644
--- a/drivers/pinctrl/realtek/Kconfig
+++ b/drivers/pinctrl/realtek/Kconfig
@@ -6,6 +6,7 @@ config PINCTRL_RTD
 	default y
 	select PINMUX
 	select GENERIC_PINCONF
+	select REGMAP_MMIO
 
 config PINCTRL_RTD1619B
 	tristate "Realtek DHC 1619B pin controller driver"
-- 
2.34.1

Re: [PATCH] pinctrl: realtek: Select REGMAP_MMIO for RTD driver

Posted by Linus Walleij 3 months, 2 weeks ago

On Thu, Oct 23, 2025 at 9:55 AM Yu-Chun Lin <eleanor.lin@realtek.com> wrote:

> The pinctrl-rtd driver uses 'devm_regmap_init_mmio', which requires
> 'REGMAP_MMIO' to be enabled.
>
> Without this selection, the build fails with an undefined reference:
> aarch64-none-linux-gnu-ld: drivers/pinctrl/realtek/pinctrl-rtd.o: in
> function rtd_pinctrl_probe': pinctrl-rtd.c:(.text+0x5a0): undefined
> reference to __devm_regmap_init_mmio_clk'
>
> Fix this by selecting 'REGMAP_MMIO' in the Kconfig.
>
> Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>

Right!
Patch applied for fixes.

Yours,
Linus Walleij