From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
There's a missing mutex_unlock() in the error-return path inside
ps883x_sw_set(). Simply delete that return since there's another one
3 lines below.
Fixes: f83cb615cb7a ("usb: typec: ps883x: Cache register settings, not Type-C mode")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202510231023.aJ09O6pk-lkp@intel.com/
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/usb/typec/mux/ps883x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c
index 7c61629b36d6..5f2879749769 100644
--- a/drivers/usb/typec/mux/ps883x.c
+++ b/drivers/usb/typec/mux/ps883x.c
@@ -192,10 +192,8 @@ static int ps883x_sw_set(struct typec_switch_dev *sw,
ret = regmap_assign_bits(retimer->regmap, REG_USB_PORT_CONN_STATUS_0,
CONN_STATUS_0_ORIENTATION_REVERSED,
orientation == TYPEC_ORIENTATION_REVERSE);
- if (ret) {
+ if (ret)
dev_err(&retimer->client->dev, "failed to set orientation: %d\n", ret);
- return ret;
- }
}
mutex_unlock(&retimer->lock);
---
base-commit: 93741bd104ce07a790519ecee3a331ee7cf61ae3
change-id: 20251023-topic-ps883x_fixup-67dc74f23a9e
Best regards,
--
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>