[PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL

Frank Li posted 6 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL
Posted by Frank Li 3 months, 2 weeks ago
Add compatible string fsl,imx8qm-ddr-pmu, fsl,imx8qxp-ddr-pmu and
fsl,imx8dxl-db-pmu (for data bus fabric).

Add clocks and clock-names for fsl,imx8dxl-db-pmu and keep the same
restriction for existing compatible strings.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/perf/fsl-imx-ddr.yaml      | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
index d2e578d6b83b8847c7a0ca9d5aeb208a90e2fa6a..13eb13a79e2100ae1d747ddf6fc4db5b470112a8 100644
--- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
+++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
@@ -14,6 +14,7 @@ properties:
     oneOf:
       - enum:
           - fsl,imx8-ddr-pmu
+          - fsl,imx8dxl-db-pmu
           - fsl,imx8m-ddr-pmu
           - fsl,imx8mq-ddr-pmu
           - fsl,imx8mm-ddr-pmu
@@ -29,6 +30,8 @@ properties:
           - const: fsl,imx8m-ddr-pmu
       - items:
           - const: fsl,imx8dxl-ddr-pmu
+          - const: fsl,imx8qm-ddr-pmu
+          - const: fsl,imx8qxp-ddr-pmu
           - const: fsl,imx8-ddr-pmu
       - items:
           - enum:
@@ -43,6 +46,14 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: cnt
+
 required:
   - compatible
   - reg
@@ -50,6 +61,21 @@ required:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx8dxl-db-pmu
+    then:
+      required:
+        - clocks
+        - clock-names
+    else:
+      properties:
+        clocks: false
+        clock-names: false
+
 examples:
   - |
     #include <dt-bindings/interrupt-controller/arm-gic.h>

-- 
2.34.1
Re: [PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL
Posted by Krzysztof Kozlowski 3 months, 2 weeks ago
On 23/10/2025 20:56, Frank Li wrote:
> Add compatible string fsl,imx8qm-ddr-pmu, fsl,imx8qxp-ddr-pmu and
> fsl,imx8dxl-db-pmu (for data bus fabric).
> 
> Add clocks and clock-names for fsl,imx8dxl-db-pmu and keep the same
> restriction for existing compatible strings.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/perf/fsl-imx-ddr.yaml      | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> index d2e578d6b83b8847c7a0ca9d5aeb208a90e2fa6a..13eb13a79e2100ae1d747ddf6fc4db5b470112a8 100644
> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> @@ -14,6 +14,7 @@ properties:
>      oneOf:
>        - enum:
>            - fsl,imx8-ddr-pmu
> +          - fsl,imx8dxl-db-pmu
>            - fsl,imx8m-ddr-pmu
>            - fsl,imx8mq-ddr-pmu
>            - fsl,imx8mm-ddr-pmu
> @@ -29,6 +30,8 @@ properties:
>            - const: fsl,imx8m-ddr-pmu
>        - items:
>            - const: fsl,imx8dxl-ddr-pmu
> +          - const: fsl,imx8qm-ddr-pmu
> +          - const: fsl,imx8qxp-ddr-pmu


I don't understand the need for this change, not explained in commit
msg. Why do you change 8dxl-ddr?

Best regards,
Krzysztof
Re: [PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL
Posted by Frank Li 3 months, 2 weeks ago
On Fri, Oct 24, 2025 at 03:03:10PM +0200, Krzysztof Kozlowski wrote:
> On 23/10/2025 20:56, Frank Li wrote:
> > Add compatible string fsl,imx8qm-ddr-pmu, fsl,imx8qxp-ddr-pmu and
> > fsl,imx8dxl-db-pmu (for data bus fabric).
> >
> > Add clocks and clock-names for fsl,imx8dxl-db-pmu and keep the same
> > restriction for existing compatible strings.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/perf/fsl-imx-ddr.yaml      | 26 ++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> > index d2e578d6b83b8847c7a0ca9d5aeb208a90e2fa6a..13eb13a79e2100ae1d747ddf6fc4db5b470112a8 100644
> > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> > @@ -14,6 +14,7 @@ properties:
> >      oneOf:
> >        - enum:
> >            - fsl,imx8-ddr-pmu
> > +          - fsl,imx8dxl-db-pmu
> >            - fsl,imx8m-ddr-pmu
> >            - fsl,imx8mq-ddr-pmu
> >            - fsl,imx8mm-ddr-pmu
> > @@ -29,6 +30,8 @@ properties:
> >            - const: fsl,imx8m-ddr-pmu
> >        - items:
> >            - const: fsl,imx8dxl-ddr-pmu
> > +          - const: fsl,imx8qm-ddr-pmu
> > +          - const: fsl,imx8qxp-ddr-pmu
>
>
> I don't understand the need for this change, not explained in commit
> msg. Why do you change 8dxl-ddr?

I have not change 8dxl-ddr, but add fsl,imx8dxl-db-pmu, which is difference
with fsl,imx8dxl-ddr-pmu. (db vs ddr). db have less events compared to
ddr's pmu.

Frank

>
> Best regards,
> Krzysztof
Re: [PATCH 1/6] dt-bindings: perf: fsl-imx-ddr: Add compatible string for i.MX8QM, i.MX8QXP and i.MX8DXL
Posted by Krzysztof Kozlowski 3 months, 2 weeks ago
On 24/10/2025 15:19, Frank Li wrote:
> On Fri, Oct 24, 2025 at 03:03:10PM +0200, Krzysztof Kozlowski wrote:
>> On 23/10/2025 20:56, Frank Li wrote:
>>> Add compatible string fsl,imx8qm-ddr-pmu, fsl,imx8qxp-ddr-pmu and
>>> fsl,imx8dxl-db-pmu (for data bus fabric).
>>>
>>> Add clocks and clock-names for fsl,imx8dxl-db-pmu and keep the same
>>> restriction for existing compatible strings.
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>>  .../devicetree/bindings/perf/fsl-imx-ddr.yaml      | 26 ++++++++++++++++++++++
>>>  1 file changed, 26 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
>>> index d2e578d6b83b8847c7a0ca9d5aeb208a90e2fa6a..13eb13a79e2100ae1d747ddf6fc4db5b470112a8 100644
>>> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
>>> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
>>> @@ -14,6 +14,7 @@ properties:
>>>      oneOf:
>>>        - enum:
>>>            - fsl,imx8-ddr-pmu
>>> +          - fsl,imx8dxl-db-pmu
>>>            - fsl,imx8m-ddr-pmu
>>>            - fsl,imx8mq-ddr-pmu
>>>            - fsl,imx8mm-ddr-pmu
>>> @@ -29,6 +30,8 @@ properties:
>>>            - const: fsl,imx8m-ddr-pmu
>>>        - items:
>>>            - const: fsl,imx8dxl-ddr-pmu
>>> +          - const: fsl,imx8qm-ddr-pmu
>>> +          - const: fsl,imx8qxp-ddr-pmu
>>
>>
>> I don't understand the need for this change, not explained in commit
>> msg. Why do you change 8dxl-ddr?
> 
> I have not change 8dxl-ddr, but add fsl,imx8dxl-db-pmu, which is difference


I talk about this exact hunk. You clearly have list for imx8dxl-ddr-pmu
being modified.

> with fsl,imx8dxl-ddr-pmu. (db vs ddr). db have less events compared to
> ddr's pmu.
> 
> Frank
> 
>>
>> Best regards,
>> Krzysztof


Best regards,
Krzysztof