[PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status

David Heidelberg via B4 Relay posted 1 patch 3 months, 2 weeks ago
Documentation/devicetree/bindings/dts-coding-style.rst | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status
Posted by David Heidelberg via B4 Relay 3 months, 2 weeks ago
From: David Heidelberg <david@ixit.cz>

For better readability, it is recommended to insert a newline before the
'status' property. Adjust the examples accordingly.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/dts-coding-style.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
index 202acac0507ab..4a02ea60cbbe2 100644
--- a/Documentation/devicetree/bindings/dts-coding-style.rst
+++ b/Documentation/devicetree/bindings/dts-coding-style.rst
@@ -120,7 +120,8 @@ The following order of properties in device nodes is preferred:
 4. Standard/common properties (defined by common bindings, e.g. without
    vendor-prefixes)
 5. Vendor-specific properties
-6. "status" (if applicable)
+6. "status" (if applicable), preceded by a blank line if there is content
+   before the property
 7. Child nodes, where each node is preceded with a blank line
 
 The "status" property is by default "okay", thus it can be omitted.
@@ -150,6 +151,7 @@ Example::
 		#address-cells = <1>;
 		#size-cells = <1>;
 		vendor,custom-property = <2>;
+
 		status = "disabled";
 
 		child_node: child-class@100 {
@@ -165,6 +167,7 @@ Example::
 		vdd-1v8-supply = <&board_vreg4>;
 		vdd-3v3-supply = <&board_vreg2>;
 		vdd-12v-supply = <&board_vreg3>;
+
 		status = "okay";
 	}
 

---
base-commit: efb26a23ed5f5dc3554886ab398f559dcb1de96b
change-id: 20251023-docs-dt-newline-7e5eb43fe0fd

Best regards,
-- 
David Heidelberg <david@ixit.cz>
Re: [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status
Posted by Rob Herring (Arm) 3 months, 2 weeks ago
On Thu, 23 Oct 2025 20:00:02 +0200, David Heidelberg wrote:
> For better readability, it is recommended to insert a newline before the
> 'status' property. Adjust the examples accordingly.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/dts-coding-style.rst | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Applied, thanks!
Re: [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status
Posted by Krzysztof Kozlowski 3 months, 2 weeks ago
On 23/10/2025 20:00, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> For better readability, it is recommended to insert a newline before the
> 'status' property. Adjust the examples accordingly.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof