Asserting or deasserting a modem control line using TIOCMBIS or TIOCMBIC
should not deassert any lines that are not in the mask, but two drivers
got this wrong.

Included are also some related cleanups.

Johan


Johan Hovold (8):
  USB: serial: belkin_sa: fix TIOCMBIS and TIOCMBIC
  USB: serial: kobil_sct: fix TIOCMBIS and TIOCMBIC
  USB: serial: belkin_sa: clean up tiocmset()
  USB: serial: kobil_sct: clean up tiocmset()
  USB: serial: kobil_sct: clean up device type checks
  USB: serial: kobil_sct: add control request helpers
  USB: serial: kobil_sct: clean up set_termios()
  USB: serial: kobil_sct: drop unnecessary initialisations

 drivers/usb/serial/belkin_sa.c |  42 +++----
 drivers/usb/serial/kobil_sct.c | 210 ++++++++++++---------------------
 2 files changed, 95 insertions(+), 157 deletions(-)

-- 
2.49.1

On Wed, Oct 22, 2025 at 05:26:32PM +0200, Johan Hovold wrote:
> Asserting or deasserting a modem control line using TIOCMBIS or TIOCMBIC
> should not deassert any lines that are not in the mask, but two drivers
> got this wrong.
> 
> Included are also some related cleanups.

Nice catch!

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

On Wed, Oct 22, 2025 at 07:14:34PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 22, 2025 at 05:26:32PM +0200, Johan Hovold wrote:
> > Asserting or deasserting a modem control line using TIOCMBIS or TIOCMBIC
> > should not deassert any lines that are not in the mask, but two drivers
> > got this wrong.
> > 
> > Included are also some related cleanups.
> 
> Nice catch!
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing. Now applied.

Johan