[v1] ALSA: maestro3: using vmalloc_array() to handle the code

[PATCH] ALSA: maestro3: using vmalloc_array() to handle the code

Posted by tanze 3 months, 2 weeks ago

Change array_size() to vmalloc_array(), Due to vmalloc_array()
is optimized better,uses fewer instructions, and handles
overflow more concisely

Signed-off-by: tanze <tanze@kylinos.cn>
---
 sound/pci/maestro3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c
index bddf47a1f263..3353980d5cd8 100644
--- a/sound/pci/maestro3.c
+++ b/sound/pci/maestro3.c
@@ -2571,9 +2571,9 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
 
 	if (IS_ENABLED(CONFIG_PM_SLEEP)) {
 		chip->suspend_mem =
-			vmalloc(array_size(sizeof(u16),
-					   REV_B_CODE_MEMORY_LENGTH +
-					   REV_B_DATA_MEMORY_LENGTH));
+			vmalloc_array(REV_B_CODE_MEMORY_LENGTH +
+				      REV_B_DATA_MEMORY_LENGTH,
+				      sizeof(u16));
 		if (!chip->suspend_mem)
 			dev_warn(card->dev, "can't allocate apm buffer\n");
 	}
-- 
2.25.1

Re: [PATCH] ALSA: maestro3: using vmalloc_array() to handle the code

Posted by Philipp Stanner 3 months, 2 weeks ago

On Wed, 2025-10-22 at 17:23 +0800, tanze wrote:
> Change array_size() to vmalloc_array(), Due to vmalloc_array()

s/Due/due

> is optimized better,uses fewer instructions, and handles

s/is/being
s/,/, /
s/uses/using
s/handles/handling

> overflow more concisely

full stop: '.'

> 
> Signed-off-by: tanze <tanze@kylinos.cn>

Is that your full name? Signed-off-by is basically a 'legal' statement
declaring that you as the code's author agree with the license and
stuff and declare that you're allowed (by your employer for example) to
upstream this code.


P.

> ---
>  sound/pci/maestro3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c
> index bddf47a1f263..3353980d5cd8 100644
> --- a/sound/pci/maestro3.c
> +++ b/sound/pci/maestro3.c
> @@ -2571,9 +2571,9 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
>  
>  	if (IS_ENABLED(CONFIG_PM_SLEEP)) {
>  		chip->suspend_mem =
> -			vmalloc(array_size(sizeof(u16),
> -					   REV_B_CODE_MEMORY_LENGTH +
> -					   REV_B_DATA_MEMORY_LENGTH));
> +			vmalloc_array(REV_B_CODE_MEMORY_LENGTH +
> +				      REV_B_DATA_MEMORY_LENGTH,
> +				      sizeof(u16));
>  		if (!chip->suspend_mem)
>  			dev_warn(card->dev, "can't allocate apm buffer\n");
>  	}