[PATCH v8 0/1] Improve usage of 'ret' variable

Cezar Chiru posted 1 patch 3 months, 2 weeks ago
drivers/i2c/algos/i2c-algo-pcf.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
[PATCH v8 0/1] Improve usage of 'ret' variable
Posted by Cezar Chiru 3 months, 2 weeks ago
Hello maintainers,

 This patch series is a response to Change Requests made by Andi Shyti on
[PATCH v7 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch
and more specific on PATCH: i2c: pcf8584: Move 'ret' variable inside for
loop, break if ret < 0.

Change Requests v7->v8:
 -Move 'ret' variable inside for loop of pcf_xfer() function.
 -remove initialization of 'ret' variable inside for loop of pcf_xfer() as
 it is not needed

PATCH 1/1: i2c: pcf8584: Move 'ret' variable inside for loop, break if ret
< 0.
This patch add spaces around binary operators as reported by checkpatch.pl
Move 'ret' variable inside for loop of pcf_xfer() function.

Testing:
   *built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
   top of 6.18.0-rc1.
   *installed kernel and external modules generated by build on my laptop
   *rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter.
   *when loading the .ko with i2c_debug parameter an error is seen in dmesg
   and this is expected as the parameter was removed.
   *No success message related to i2c_algo_pcf was seen in dmesg but also
   no failures.
   *Module loading and unloading successful.
   *No PCF8584 Hardware was available.



Cezar Chiru (1):
  i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0.

 drivers/i2c/algos/i2c-algo-pcf.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

--
2.43.0