1. Patchew
  2. linux
  3. View series

[PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon

Marcus Folkesson posted 1 patch 3 months, 2 weeks ago 
drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
Posted by Marcus Folkesson 3 months, 2 weeks ago 
Fix style issue reported by Kernel test robot.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
--- a/drivers/gpu/drm/sitronix/st7571-i2c.c
+++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
@@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
 		size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
 		memcpy(st7571->hwbuf, vmap->vaddr, size);
 		break;
-	};
+	}
 }
 
 static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)

---
base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
change-id: 20251022-st7571-semicolon-bc5287cde264

Best regards,
-- 
Marcus Folkesson <marcus.folkesson@gmail.com>
Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
Posted by Marcus Folkesson 3 months, 2 weeks ago 
On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
> Fix style issue reported by Kernel test robot.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>  drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
>  		size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
>  		memcpy(st7571->hwbuf, vmap->vaddr, size);
>  		break;
> -	};
> +	}
>  }
>  
>  static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
> 
> ---
> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
> change-id: 20251022-st7571-semicolon-bc5287cde264
> 
> Best regards,
> -- 
> Marcus Folkesson <marcus.folkesson@gmail.com>
> 

Pushed to drm-misc-fixes.

Best regards,
Marcus Folkesson
Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
Posted by Thomas Zimmermann 3 months, 2 weeks ago 
Hi

Am 22.10.25 um 09:59 schrieb Marcus Folkesson:
> On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
>> Fix style issue reported by Kernel test robot.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> ---
>>   drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
>> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
>> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
>> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
>> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
>>   		size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
>>   		memcpy(st7571->hwbuf, vmap->vaddr, size);
>>   		break;
>> -	};
>> +	}
>>   }
>>   
>>   static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
>>
>> ---
>> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
>> change-id: 20251022-st7571-semicolon-bc5287cde264
>>
>> Best regards,
>> -- 
>> Marcus Folkesson <marcus.folkesson@gmail.com>
>>
> Pushed to drm-misc-fixes.

This does not belong into -fixes as it's not a bug fix, just a style 
issue. Also misses the Fixes tag. No need to revert, but please keep in 
mind for next time.

Best regards
Thomas

>
> Best regards,
> Marcus Folkesson

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
Posted by Marcus Folkesson 3 months, 2 weeks ago 
Hi,

On Wed, Oct 22, 2025 at 10:19:13AM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 22.10.25 um 09:59 schrieb Marcus Folkesson:
> > On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
> > > Fix style issue reported by Kernel test robot.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
> > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > > ---
> > >   drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> > > index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
> > > --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> > > +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> > > @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
> > >   		size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
> > >   		memcpy(st7571->hwbuf, vmap->vaddr, size);
> > >   		break;
> > > -	};
> > > +	}
> > >   }
> > >   static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
> > > 
> > > ---
> > > base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
> > > change-id: 20251022-st7571-semicolon-bc5287cde264
> > > 
> > > Best regards,
> > > -- 
> > > Marcus Folkesson <marcus.folkesson@gmail.com>
> > > 
> > Pushed to drm-misc-fixes.

s/drm-misc-fixes/drm-misc-next/
> 
> This does not belong into -fixes as it's not a bug fix, just a style issue.
> Also misses the Fixes tag. No need to revert, but please keep in mind for
> next time.

Ooops, it was pushed to drm-misc-next, not drm-misc-fixes.
Sorry for the typo and thanks for pointing it out.

Best regards,
Marcus Folkesson








> 
> Best regards
> Thomas
> 
> > 
> > Best regards,
> > Marcus Folkesson
> 
> -- 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
> 
>
Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon
Posted by Thomas Zimmermann 3 months, 2 weeks ago 

Am 22.10.25 um 08:10 schrieb Marcus Folkesson:
> Fix style issue reported by Kernel test robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
>   		size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
>   		memcpy(st7571->hwbuf, vmap->vaddr, size);
>   		break;
> -	};
> +	}
>   }
>   
>   static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
>
> ---
> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
> change-id: 20251022-st7571-semicolon-bc5287cde264
>
> Best regards,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.