[PATCH v2 01/26] drm/xe/pf: Remove GuC version check for migration support

Michał Winiarski posted 26 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 01/26] drm/xe/pf: Remove GuC version check for migration support
Posted by Michał Winiarski 3 months, 2 weeks ago
Since commit 4eb0aab6e4434 ("drm/xe/guc: Bump minimum required GuC
version to v70.29.2"), the minimum GuC version required by the driver
is v70.29.2, which should already include everything that we need for
migration.
Remove the version check.

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c
index 44cc612b0a752..a5bf327ef8889 100644
--- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c
+++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c
@@ -384,9 +384,6 @@ ssize_t xe_gt_sriov_pf_migration_write_guc_state(struct xe_gt *gt, unsigned int
 
 static bool pf_check_migration_support(struct xe_gt *gt)
 {
-	/* GuC 70.25 with save/restore v2 is required */
-	xe_gt_assert(gt, GUC_FIRMWARE_VER(&gt->uc.guc) >= MAKE_GUC_VER(70, 25, 0));
-
 	/* XXX: for now this is for feature enabling only */
 	return IS_ENABLED(CONFIG_DRM_XE_DEBUG);
 }
-- 
2.50.1

RE: [PATCH v2 01/26] drm/xe/pf: Remove GuC version check for migration support
Posted by Tian, Kevin 3 months, 2 weeks ago
> From: Winiarski, Michal <michal.winiarski@intel.com>
> Sent: Wednesday, October 22, 2025 6:41 AM
> 
>  static bool pf_check_migration_support(struct xe_gt *gt)
>  {
> -	/* GuC 70.25 with save/restore v2 is required */
> -	xe_gt_assert(gt, GUC_FIRMWARE_VER(&gt->uc.guc) >=
> MAKE_GUC_VER(70, 25, 0));
> -
>  	/* XXX: for now this is for feature enabling only */
>  	return IS_ENABLED(CONFIG_DRM_XE_DEBUG);

why putting it under a debug option? Now you are sending formal
series for merge, assuming good quality.
Re: [PATCH v2 01/26] drm/xe/pf: Remove GuC version check for migration support
Posted by Winiarski, Michal 3 months, 2 weeks ago
On Tue, Oct 28, 2025 at 03:33:22AM +0100, Tian, Kevin wrote:
> > From: Winiarski, Michal <michal.winiarski@intel.com>
> > Sent: Wednesday, October 22, 2025 6:41 AM
> > 
> >  static bool pf_check_migration_support(struct xe_gt *gt)
> >  {
> > -	/* GuC 70.25 with save/restore v2 is required */
> > -	xe_gt_assert(gt, GUC_FIRMWARE_VER(&gt->uc.guc) >=
> > MAKE_GUC_VER(70, 25, 0));
> > -
> >  	/* XXX: for now this is for feature enabling only */
> >  	return IS_ENABLED(CONFIG_DRM_XE_DEBUG);
> 
> why putting it under a debug option? Now you are sending formal
> series for merge, assuming good quality.

The need for debug option is removed for specific platforms in Patch
24/26, but I will drop it completely in v3.

-Michał