dma-fence: Fix safe access wrapper to call timeline name method

[PATCH] dma-fence: Fix safe access wrapper to call timeline name method

Posted by Akash Goel 3 months, 2 weeks ago

This commit fixes the wrapper function dma_fence_timeline_name(), that
was added for safe access, to actually call the timeline name method of
dma_fence_ops.

Cc: <stable@vger.kernel.org> # v6.17+
Signed-off-by: Akash Goel <akash.goel@arm.com>
---
 drivers/dma-buf/dma-fence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 3f78c56b58dc..39e6f93dc310 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -1141,7 +1141,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
 			 "RCU protection is required for safe access to returned string");
 
 	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
-		return fence->ops->get_driver_name(fence);
+		return fence->ops->get_timeline_name(fence);
 	else
 		return "signaled-timeline";
 }
-- 
2.25.1

Re: [PATCH] dma-fence: Fix safe access wrapper to call timeline name method

Posted by Tvrtko Ursulin 3 months, 2 weeks ago

On 21/10/2025 17:09, Akash Goel wrote:
> This commit fixes the wrapper function dma_fence_timeline_name(), that
> was added for safe access, to actually call the timeline name method of
> dma_fence_ops.
> 
> Cc: <stable@vger.kernel.org> # v6.17+
> Signed-off-by: Akash Goel <akash.goel@arm.com>

Fixes: 506aa8b02a8d ("dma-fence: Add safe access helpers and document 
the rules")

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

Apologies for the copy and paste snafu.

Regards,

Tvrtko

> ---
>   drivers/dma-buf/dma-fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 3f78c56b58dc..39e6f93dc310 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -1141,7 +1141,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
>   			 "RCU protection is required for safe access to returned string");
>   
>   	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
> -		return fence->ops->get_driver_name(fence);
> +		return fence->ops->get_timeline_name(fence);
>   	else
>   		return "signaled-timeline";
>   }

Re: [PATCH] dma-fence: Fix safe access wrapper to call timeline name method

Posted by Christian König 3 months, 1 week ago

On 10/21/25 20:36, Tvrtko Ursulin wrote:
> 
> On 21/10/2025 17:09, Akash Goel wrote:
>> This commit fixes the wrapper function dma_fence_timeline_name(), that
>> was added for safe access, to actually call the timeline name method of
>> dma_fence_ops.
>>
>> Cc: <stable@vger.kernel.org> # v6.17+
>> Signed-off-by: Akash Goel <akash.goel@arm.com>
> 
> Fixes: 506aa8b02a8d ("dma-fence: Add safe access helpers and document the rules")
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

Good catch, Reviewed-by: Christian König <christian.koenig@amd.com> as well.

Please ping me if you need somebody to push this to drm-misc-fixes.

Thanks,
Christian.

> 
> Apologies for the copy and paste snafu.
> 
> Regards,
> 
> Tvrtko
> 
>> ---
>>   drivers/dma-buf/dma-fence.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
>> index 3f78c56b58dc..39e6f93dc310 100644
>> --- a/drivers/dma-buf/dma-fence.c
>> +++ b/drivers/dma-buf/dma-fence.c
>> @@ -1141,7 +1141,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
>>                "RCU protection is required for safe access to returned string");
>>         if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>> -        return fence->ops->get_driver_name(fence);
>> +        return fence->ops->get_timeline_name(fence);
>>       else
>>           return "signaled-timeline";
>>   }
>