[v4] of/irq: Misc msi-parent handling fixes/clean-ups

[PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups

Posted by Lorenzo Pieralisi 1 month, 4 weeks ago

This is series is a follow up to [1] - with additional patches that are
addressing Rob's feedback (pcie-layerscape-gen4 was removed from the
kernel, Yay !) and other bits and bobs I noticed while staring at the code.

Patch (1) is a fix and technically we would like to get it in v6.18 please.

Patch (4) is compile-tested only, I can not run it on HW, I do not have it,
Scott, Ray please test it if you can.

v3 -> v4:
	- Addressed Rob's review
	- Added trailers
	- Rebased against v6.18-rc2

v2 -> v3:
	- Added additional patch to export of_msi_xlate()
	- Addressed review feedback

v3: https://lore.kernel.org/lkml/20251017084752.1590264-1-lpieralisi@kernel.org/
v2: https://lore.kernel.org/lkml/20251014095845.1310624-1-lpieralisi@kernel.org/
v1: https://lore.kernel.org/lkml/20250916091858.257868-1-lpieralisi@kernel.org/

[1] https://lore.kernel.org/lkml/20250916091858.257868-1-lpieralisi@kernel.org/

Cc: Sascha Bischoff <sascha.bischoff@arm.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>

Lorenzo Pieralisi (5):
  of/irq: Add msi-parent check to of_msi_xlate()
  of/irq: Fix OF node refcount in of_msi_get_domain()
  of/irq: Export of_msi_xlate() for module usage
  PCI: iproc: Implement MSI controller node detection with
    of_msi_xlate()
  irqchip/gic-its: Rework platform MSI deviceID detection

 drivers/irqchip/irq-gic-its-msi-parent.c | 91 ++++++------------------
 drivers/of/irq.c                         | 44 ++++++++++--
 drivers/pci/controller/pcie-iproc.c      | 22 ++----
 3 files changed, 68 insertions(+), 89 deletions(-)

-- 
2.50.1

Re: [PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups

Posted by Rob Herring 1 month, 4 weeks ago

On Tue, Oct 21, 2025 at 02:40:58PM +0200, Lorenzo Pieralisi wrote:
> This is series is a follow up to [1] - with additional patches that are
> addressing Rob's feedback (pcie-layerscape-gen4 was removed from the
> kernel, Yay !) and other bits and bobs I noticed while staring at the code.
> 
> Patch (1) is a fix and technically we would like to get it in v6.18 please.
> 
> Patch (4) is compile-tested only, I can not run it on HW, I do not have it,
> Scott, Ray please test it if you can.
> 
> v3 -> v4:
> 	- Addressed Rob's review
> 	- Added trailers
> 	- Rebased against v6.18-rc2
> 
> v2 -> v3:
> 	- Added additional patch to export of_msi_xlate()
> 	- Addressed review feedback
> 
> v3: https://lore.kernel.org/lkml/20251017084752.1590264-1-lpieralisi@kernel.org/
> v2: https://lore.kernel.org/lkml/20251014095845.1310624-1-lpieralisi@kernel.org/
> v1: https://lore.kernel.org/lkml/20250916091858.257868-1-lpieralisi@kernel.org/
> 
> [1] https://lore.kernel.org/lkml/20250916091858.257868-1-lpieralisi@kernel.org/
> 
> Cc: Sascha Bischoff <sascha.bischoff@arm.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> 
> Lorenzo Pieralisi (5):
>   of/irq: Add msi-parent check to of_msi_xlate()
>   of/irq: Fix OF node refcount in of_msi_get_domain()

I've applied these 2 for 6.18.

>   of/irq: Export of_msi_xlate() for module usage
>   PCI: iproc: Implement MSI controller node detection with
>     of_msi_xlate()
>   irqchip/gic-its: Rework platform MSI deviceID detection
> 
>  drivers/irqchip/irq-gic-its-msi-parent.c | 91 ++++++------------------
>  drivers/of/irq.c                         | 44 ++++++++++--
>  drivers/pci/controller/pcie-iproc.c      | 22 ++----
>  3 files changed, 68 insertions(+), 89 deletions(-)
> 
> -- 
> 2.50.1
>

Re: [PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups

Posted by Thomas Gleixner 1 month, 3 weeks ago

Rob!

On Wed, Oct 22 2025 at 09:05, Rob Herring wrote:
> On Tue, Oct 21, 2025 at 02:40:58PM +0200, Lorenzo Pieralisi wrote:
>> Lorenzo Pieralisi (5):
>>   of/irq: Add msi-parent check to of_msi_xlate()
>>   of/irq: Fix OF node refcount in of_msi_get_domain()
>
> I've applied these 2 for 6.18.

The rest of this depends on those two.

>>   of/irq: Export of_msi_xlate() for module usage

Can you pick the three of/irq ones up and put them into a seperate
branch based on rc1 so that I can pull that and apply the rest:

>>   PCI: iproc: Implement MSI controller node detection with
>>     of_msi_xlate()
>>   irqchip/gic-its: Rework platform MSI deviceID detection

Thanks,

        tglx

Re: [PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups

Posted by Rob Herring 1 month, 3 weeks ago

On Fri, Oct 24, 2025 at 4:44 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Rob!
>
> On Wed, Oct 22 2025 at 09:05, Rob Herring wrote:
> > On Tue, Oct 21, 2025 at 02:40:58PM +0200, Lorenzo Pieralisi wrote:
> >> Lorenzo Pieralisi (5):
> >>   of/irq: Add msi-parent check to of_msi_xlate()
> >>   of/irq: Fix OF node refcount in of_msi_get_domain()
> >
> > I've applied these 2 for 6.18.
>
> The rest of this depends on those two.
>
> >>   of/irq: Export of_msi_xlate() for module usage
>
> Can you pick the three of/irq ones up and put them into a seperate
> branch based on rc1 so that I can pull that and apply the rest:

Yes. This series is the only thing I have queued for 6.18 fixes so
far, so I'll add the 3rd patch and Cc you on my PR to Linus.

Rob

Re: [PATCH v4 0/5] of/irq: Misc msi-parent handling fixes/clean-ups

Posted by Thomas Gleixner 1 month, 3 weeks ago

On Fri, Oct 24 2025 at 07:43, Rob Herring wrote:
> On Fri, Oct 24, 2025 at 4:44 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Wed, Oct 22 2025 at 09:05, Rob Herring wrote:
>> > On Tue, Oct 21, 2025 at 02:40:58PM +0200, Lorenzo Pieralisi wrote:
>> >> Lorenzo Pieralisi (5):
>> >>   of/irq: Add msi-parent check to of_msi_xlate()
>> >>   of/irq: Fix OF node refcount in of_msi_get_domain()
>> >
>> > I've applied these 2 for 6.18.
>>
>> The rest of this depends on those two.
>>
>> >>   of/irq: Export of_msi_xlate() for module usage
>>
>> Can you pick the three of/irq ones up and put them into a seperate
>> branch based on rc1 so that I can pull that and apply the rest:
>
> Yes. This series is the only thing I have queued for 6.18 fixes so
> far, so I'll add the 3rd patch and Cc you on my PR to Linus.

Thanks!