soundwire: send multi sections in one BPT stream

[PATCH 0/3] soundwire: send multi sections in one BPT stream

Posted by Bard Liao 3 months, 2 weeks ago

Currently we send a BRA message with a start address with continuous
registers in a BPT stream. However, a codec may need to write different
register sections shortly. It makes more sense to send different
register sections in a BPT stream and no need to close/open the BPT
stream repeatedly.

This series depends on the "ASoC/soundwire: add fake BPT frame to align
Intel DMA buffer size" series. Sending it now to get more review time.

Bard Liao (3):
  soundwire: introduce BPT section
  soundwire: pass sdw_bpt_section to cdns BPT helpers
  soundwire: intel_ace2x: handle multi BPT sections

 drivers/soundwire/bus.c            |  10 +-
 drivers/soundwire/bus.h            |  22 ++-
 drivers/soundwire/cadence_master.c | 218 +++++++++++++++++------------
 drivers/soundwire/cadence_master.h |  12 +-
 drivers/soundwire/debugfs.c        |  14 +-
 drivers/soundwire/intel_ace2x.c    |  47 +++++--
 6 files changed, 205 insertions(+), 118 deletions(-)

-- 
2.43.0

Re: [PATCH 0/3] soundwire: send multi sections in one BPT stream

Posted by Vinod Koul 2 months, 3 weeks ago

On Tue, 21 Oct 2025 17:43:51 +0800, Bard Liao wrote:
> Currently we send a BRA message with a start address with continuous
> registers in a BPT stream. However, a codec may need to write different
> register sections shortly. It makes more sense to send different
> register sections in a BPT stream and no need to close/open the BPT
> stream repeatedly.
> 
> This series depends on the "ASoC/soundwire: add fake BPT frame to align
> Intel DMA buffer size" series. Sending it now to get more review time.
> 
> [...]

Applied, thanks!

[1/3] soundwire: introduce BPT section
      commit: 96755433031e426353cee230abd0e6170d386787
[2/3] soundwire: pass sdw_bpt_section to cdns BPT helpers
      commit: 1fdffb2012767f12bba6bb5646a6967e5607caec
[3/3] soundwire: intel_ace2x: handle multi BPT sections
      commit: 336859050e5844b2e8b601dd126d5dc46f6c00f4

Best regards,
-- 
~Vinod

Re: [PATCH 0/3] soundwire: send multi sections in one BPT stream

Posted by Vinod Koul 2 months, 3 weeks ago

On 21-10-25, 17:43, Bard Liao wrote:
> Currently we send a BRA message with a start address with continuous
> registers in a BPT stream. However, a codec may need to write different
> register sections shortly. It makes more sense to send different
> register sections in a BPT stream and no need to close/open the BPT
> stream repeatedly.
> 
> This series depends on the "ASoC/soundwire: add fake BPT frame to align
> Intel DMA buffer size" series. Sending it now to get more review time.

I have applied it on top of above series, pls check why it is not
applying in :
error: patch failed: drivers/soundwire/intel_ace2x.c:156
error: drivers/soundwire/intel_ace2x.c: patch does not apply

-- 
~Vinod

Re: [PATCH 0/3] soundwire: send multi sections in one BPT stream

Posted by Liao, Bard 2 months, 3 weeks ago

On 11/12/2025 1:12 PM, Vinod Koul wrote:
> On 21-10-25, 17:43, Bard Liao wrote:
>> Currently we send a BRA message with a start address with continuous
>> registers in a BPT stream. However, a codec may need to write different
>> register sections shortly. It makes more sense to send different
>> register sections in a BPT stream and no need to close/open the BPT
>> stream repeatedly.
>>
>> This series depends on the "ASoC/soundwire: add fake BPT frame to align
>> Intel DMA buffer size" series. Sending it now to get more review time.
> 
> I have applied it on top of above series, pls check why it is not
> applying in :
> error: patch failed: drivers/soundwire/intel_ace2x.c:156
> error: drivers/soundwire/intel_ace2x.c: patch does not apply
> 

Hi Vinod,

I just tried "git am" this series again and it can apply on top of
04878e873d94 ("ASoC/soundwire: add fake BPT frame to align Intel DMA
buffer size").
Also, I checked drivers/soundwire/intel_ace2x.c line 156 and it has the
same content as the "soundwire: introduce BPT section" patch.
Sorry, I have no idea why it didn't apply. Could you please try again?

Re: [PATCH 0/3] soundwire: send multi sections in one BPT stream

Posted by Vinod Koul 2 months, 3 weeks ago

On 12-11-25, 14:13, Liao, Bard wrote:
> 
> 
> On 11/12/2025 1:12 PM, Vinod Koul wrote:
> > On 21-10-25, 17:43, Bard Liao wrote:
> >> Currently we send a BRA message with a start address with continuous
> >> registers in a BPT stream. However, a codec may need to write different
> >> register sections shortly. It makes more sense to send different
> >> register sections in a BPT stream and no need to close/open the BPT
> >> stream repeatedly.
> >>
> >> This series depends on the "ASoC/soundwire: add fake BPT frame to align
> >> Intel DMA buffer size" series. Sending it now to get more review time.
> > 
> > I have applied it on top of above series, pls check why it is not
> > applying in :
> > error: patch failed: drivers/soundwire/intel_ace2x.c:156
> > error: drivers/soundwire/intel_ace2x.c: patch does not apply
> > 
> 
> Hi Vinod,
> 
> I just tried "git am" this series again and it can apply on top of
> 04878e873d94 ("ASoC/soundwire: add fake BPT frame to align Intel DMA
> buffer size").
> Also, I checked drivers/soundwire/intel_ace2x.c line 156 and it has the
> same content as the "soundwire: introduce BPT section" patch.
> Sorry, I have no idea why it didn't apply. Could you please try again?

Yeah I fixed the commit base and it worked, thanks

-- 
~Vinod