[v2] General RK3368 HDMI support and 2 outputs for RK3368-Lion

[PATCH v2 5/9] arm64: dts: rockchip: Add power-domain to RK3368 VOP controller

Posted by Heiko Stuebner 3 months, 3 weeks ago

From: Heiko Stuebner <heiko.stuebner@cherry.de>

The VOP is also part of the VIO power-domain and it definitely needs to
be on when accessing it to not cause SError faults, so add the
power-domains property to it.

Fixes: ef06b5ddee1e ("arm64: dts: rockchip: Add display subsystem for RK3368")
Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
 arch/arm64/boot/dts/rockchip/rk3368.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index 5b2cbb3003b6..ce4b112b082b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -862,6 +862,7 @@ vop: vop@ff930000 {
 		clocks = <&cru ACLK_VOP>, <&cru DCLK_VOP>, <&cru HCLK_VOP>;
 		clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
 		iommus = <&vop_mmu>;
+		power-domains = <&power RK3368_PD_VIO>;
 		resets = <&cru SRST_LCDC0_AXI>, <&cru SRST_LCDC0_AHB>, <&cru SRST_LCDC0_DCLK>;
 		reset-names = "axi", "ahb", "dclk";
 		status = "disabled";
-- 
2.47.2

Re: [PATCH v2 5/9] arm64: dts: rockchip: Add power-domain to RK3368 VOP controller

Posted by Quentin Schulz 2 months, 1 week ago

Hi Heiko,

On 10/21/25 9:42 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> The VOP is also part of the VIO power-domain and it definitely needs to
> be on when accessing it to not cause SError faults, so add the
> power-domains property to it.
> 
> Fixes: ef06b5ddee1e ("arm64: dts: rockchip: Add display subsystem for RK3368")

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin