[PATCH v5 0/3] Add pinctrl support for Sky1

Gary Yang posted 3 patches 1 month, 3 weeks ago
.../bindings/pinctrl/cix,sky1-pinctrl.yaml    |  92 +++
arch/arm64/boot/dts/cix/sky1-orion-o6.dts     |  32 +
arch/arm64/boot/dts/cix/sky1-pinfunc.h        | 401 ++++++++++++
arch/arm64/boot/dts/cix/sky1.dtsi             |  10 +
drivers/pinctrl/Kconfig                       |   1 +
drivers/pinctrl/Makefile                      |   1 +
drivers/pinctrl/cix/Kconfig                   |  14 +
drivers/pinctrl/cix/Makefile                  |   4 +
drivers/pinctrl/cix/pinctrl-sky1-base.c       | 573 ++++++++++++++++++
drivers/pinctrl/cix/pinctrl-sky1.c            | 559 +++++++++++++++++
drivers/pinctrl/cix/pinctrl-sky1.h            |  48 ++
11 files changed, 1735 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
create mode 100644 arch/arm64/boot/dts/cix/sky1-pinfunc.h
create mode 100644 drivers/pinctrl/cix/Kconfig
create mode 100644 drivers/pinctrl/cix/Makefile
create mode 100644 drivers/pinctrl/cix/pinctrl-sky1-base.c
create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.c
create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.h
[PATCH v5 0/3] Add pinctrl support for Sky1
Posted by Gary Yang 1 month, 3 weeks ago
Patch 1: Add dt-binding doc for pinctrl on Sky1
Patch 2: Add pin-controller driver for sky1
Patch 3: Add pinctrl nodes for sky1

Changes for v5:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Drop DS_LEVELX macro
- Fix dt-bindings style
- Fix build warning

Changes for v4:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- support driver_strength = <8> (mA)
- Fix dt-bindings style

Changes for v3:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Re-order the patch set, and move dt-bindings to the 1st patch.
- Refine the pinctrl driver with SKY_PINFUNCTION macro
- Fix warnings when make dt_binding_check

Changes for v2:
- restructure the pinctrl driver to support pinmux=<..>
- redefine pinmux macros
- move header file from dt-bindings to dts
- fix the code-style issues

Gary Yang (3):
  dt-bindings: pinctrl: Add cix,sky1-pinctrl
  pinctrl: cix: Add pin-controller support for sky1
  arm64: dts: cix: Add pinctrl nodes for sky1

 .../bindings/pinctrl/cix,sky1-pinctrl.yaml    |  92 +++
 arch/arm64/boot/dts/cix/sky1-orion-o6.dts     |  32 +
 arch/arm64/boot/dts/cix/sky1-pinfunc.h        | 401 ++++++++++++
 arch/arm64/boot/dts/cix/sky1.dtsi             |  10 +
 drivers/pinctrl/Kconfig                       |   1 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/cix/Kconfig                   |  14 +
 drivers/pinctrl/cix/Makefile                  |   4 +
 drivers/pinctrl/cix/pinctrl-sky1-base.c       | 573 ++++++++++++++++++
 drivers/pinctrl/cix/pinctrl-sky1.c            | 559 +++++++++++++++++
 drivers/pinctrl/cix/pinctrl-sky1.h            |  48 ++
 11 files changed, 1735 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
 create mode 100644 arch/arm64/boot/dts/cix/sky1-pinfunc.h
 create mode 100644 drivers/pinctrl/cix/Kconfig
 create mode 100644 drivers/pinctrl/cix/Makefile
 create mode 100644 drivers/pinctrl/cix/pinctrl-sky1-base.c
 create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.c
 create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.h

-- 
2.49.0
Re: [PATCH v5 0/3] Add pinctrl support for Sky1
Posted by Linus Walleij 1 month, 2 weeks ago
Hi Gary,

On Tue, Oct 21, 2025 at 9:04 AM Gary Yang <gary.yang@cixtech.com> wrote:

> Gary Yang (3):
>   dt-bindings: pinctrl: Add cix,sky1-pinctrl
>   pinctrl: cix: Add pin-controller support for sky1

Patches 1 & 2 applied to the pin control tree for v6.19!

>   arm64: dts: cix: Add pinctrl nodes for sky1

This third patch should be applied to the SoC tree, Peter Chen or
Fugang Duan takes care of that I think? Not sure.

Good work with the pin controller, now is a good time to just
go on from here and fix the GPIO controllers using the pin
controller as back-end too :)

Yours,
Linus Walleij
Re: [PATCH v5 0/3] Add pinctrl support for Sky1
Posted by Peter Chen 1 month, 2 weeks ago
On 25-10-27 22:56:56, Linus Walleij wrote:
> EXTERNAL EMAIL
> 
> Hi Gary,
> 
> On Tue, Oct 21, 2025 at 9:04 AM Gary Yang <gary.yang@cixtech.com> wrote:
> 
> > Gary Yang (3):
> >   dt-bindings: pinctrl: Add cix,sky1-pinctrl
> >   pinctrl: cix: Add pin-controller support for sky1
> 
> Patches 1 & 2 applied to the pin control tree for v6.19!
> 
> >   arm64: dts: cix: Add pinctrl nodes for sky1
> 
> This third patch should be applied to the SoC tree, Peter Chen or
> Fugang Duan takes care of that I think? Not sure.

Thanks, Linus.
Yes, since you have applied driver and dt-binding patches, I will
apply Dts patch to CIX SoC Tree.

-- 

Best regards,
Peter