[PATCH 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194

Aaron Kling via B4 Relay posted 5 patches 12 hours ago
There is a newer version of this series
drivers/memory/tegra/tegra186-emc.c      | 132 ++++++++++++++++++++++++++++++-
drivers/memory/tegra/tegra186.c          |  48 +++++++++++
drivers/memory/tegra/tegra194.c          |  59 +++++++++++++-
include/dt-bindings/memory/tegra186-mc.h |   4 +
include/dt-bindings/memory/tegra194-mc.h |   6 ++
5 files changed, 246 insertions(+), 3 deletions(-)
[PATCH 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194
Posted by Aaron Kling via B4 Relay 12 hours ago
This series borrows the concept used on Tegra234 to scale EMC based on
CPU frequency and applies it to Tegra186 and Tegra194. Except that the
bpmp on those archs does not support bandwidth manager, so the scaling
iteself is handled similar to how Tegra124 currently works.

This was originally part of a larger series [0], but it was requested to
be split into smaller series.

[0] https://lore.kernel.org/r/20250909-tegra186-icc-v2-0-09413724e781@gmail.com

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
Aaron Kling (5):
      dt-bindings: memory: tegra186-mc: Add dummy client IDs for Tegra186
      dt-bindings: memory: tegra194-mc: Add dummy client IDs for Tegra194
      memory: tegra186-emc: Support non-bpmp icc scaling
      memory: tegra186: Support icc scaling
      memory: tegra194: Support icc scaling

 drivers/memory/tegra/tegra186-emc.c      | 132 ++++++++++++++++++++++++++++++-
 drivers/memory/tegra/tegra186.c          |  48 +++++++++++
 drivers/memory/tegra/tegra194.c          |  59 +++++++++++++-
 include/dt-bindings/memory/tegra186-mc.h |   4 +
 include/dt-bindings/memory/tegra194-mc.h |   6 ++
 5 files changed, 246 insertions(+), 3 deletions(-)
---
base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada
change-id: 20251021-tegra186-icc-p2-864fd8625699

Best regards,
-- 
Aaron Kling <webgeek1234@gmail.com>
Re: [PATCH 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194
Posted by Krzysztof Kozlowski 11 hours ago
On 21/10/2025 20:29, Aaron Kling via B4 Relay wrote:
> This series borrows the concept used on Tegra234 to scale EMC based on
> CPU frequency and applies it to Tegra186 and Tegra194. Except that the
> bpmp on those archs does not support bandwidth manager, so the scaling
> iteself is handled similar to how Tegra124 currently works.
> 
> This was originally part of a larger series [0], but it was requested to
> be split into smaller series.
> 
> [0] https://lore.kernel.org/r/20250909-tegra186-icc-v2-0-09413724e781@gmail.com

Please keep correct versioning and changelog in the future. Try yourself:

b4 diff '<20251021-tegra186-icc-p2-v1-0-39d53bdc9aab@gmail.com>'
Grabbing thread from
lore.kernel.org/all/20251021-tegra186-icc-p2-v1-0-39d53bdc9aab@gmail.com/t.mbox.gz
---
Analyzing 6 messages in the thread
Could not find lower series to compare against.

I think I emphasized last time how important is to make it readable and
easy for maintainers.

Best regards,
Krzysztof
Re: [PATCH 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194
Posted by Aaron Kling 11 hours ago
On Tue, Oct 21, 2025 at 2:11 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 21/10/2025 20:29, Aaron Kling via B4 Relay wrote:
> > This series borrows the concept used on Tegra234 to scale EMC based on
> > CPU frequency and applies it to Tegra186 and Tegra194. Except that the
> > bpmp on those archs does not support bandwidth manager, so the scaling
> > iteself is handled similar to how Tegra124 currently works.
> >
> > This was originally part of a larger series [0], but it was requested to
> > be split into smaller series.
> >
> > [0] https://lore.kernel.org/r/20250909-tegra186-icc-v2-0-09413724e781@gmail.com
>
> Please keep correct versioning and changelog in the future. Try yourself:
>
> b4 diff '<20251021-tegra186-icc-p2-v1-0-39d53bdc9aab@gmail.com>'
> Grabbing thread from
> lore.kernel.org/all/20251021-tegra186-icc-p2-v1-0-39d53bdc9aab@gmail.com/t.mbox.gz
> ---
> Analyzing 6 messages in the thread
> Could not find lower series to compare against.
>
> I think I emphasized last time how important is to make it readable and
> easy for maintainers.

You said to split it, which I don't see how that means anything other
than 'make new series'. How am I supposed to keep versioning when I
had to make three entirely new series?

Aaron
Re: [PATCH 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194
Posted by Krzysztof Kozlowski 11 hours ago
On 21/10/2025 21:19, Aaron Kling wrote:
> On Tue, Oct 21, 2025 at 2:11 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 21/10/2025 20:29, Aaron Kling via B4 Relay wrote:
>>> This series borrows the concept used on Tegra234 to scale EMC based on
>>> CPU frequency and applies it to Tegra186 and Tegra194. Except that the
>>> bpmp on those archs does not support bandwidth manager, so the scaling
>>> iteself is handled similar to how Tegra124 currently works.
>>>
>>> This was originally part of a larger series [0], but it was requested to
>>> be split into smaller series.
>>>
>>> [0] https://lore.kernel.org/r/20250909-tegra186-icc-v2-0-09413724e781@gmail.com
>>
>> Please keep correct versioning and changelog in the future. Try yourself:
>>
>> b4 diff '<20251021-tegra186-icc-p2-v1-0-39d53bdc9aab@gmail.com>'
>> Grabbing thread from
>> lore.kernel.org/all/20251021-tegra186-icc-p2-v1-0-39d53bdc9aab@gmail.com/t.mbox.gz
>> ---
>> Analyzing 6 messages in the thread
>> Could not find lower series to compare against.
>>
>> I think I emphasized last time how important is to make it readable and
>> easy for maintainers.
> 
> You said to split it, which I don't see how that means anything other
> than 'make new series'. How am I supposed to keep versioning when I

New series with old changelog! Why splitting means that entire old
discussions, old tags, old reviews, everything should be discarded?

> had to make three entirely new series?

I do not see where is the problem - it is trivial. If you use git, you
just keep numbering. If you use b4, you just force-revision n+1.

Best regards,
Krzysztof