Replace BUG_ON() checks for invalid channel indices with proper checks
and return -EINVAL to avoid crashing the kernel unnecessarily.
Signed-off-by: Olle Lukowski <olle@lukowski.dev>
---
drivers/staging/most/i2c/i2c.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/i2c.c
index 184b2dd11..db806b00d 100644
--- a/drivers/staging/most/i2c/i2c.c
+++ b/drivers/staging/most/i2c/i2c.c
@@ -71,7 +71,8 @@ static int configure_channel(struct most_interface *most_iface,
struct hdm_i2c *dev = to_hdm(most_iface);
unsigned int delay, pr;
- BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+ if (ch_idx < 0 || ch_idx >= NUM_CHANNELS)
+ return -EINVAL;
if (channel_config->data_type != MOST_CH_CONTROL) {
pr_err("bad data type for channel %d\n", ch_idx);
@@ -125,7 +126,8 @@ static int enqueue(struct most_interface *most_iface,
struct hdm_i2c *dev = to_hdm(most_iface);
int ret;
- BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+ if (ch_idx < 0 || ch_idx >= NUM_CHANNELS)
+ return -EINVAL;
if (ch_idx == CH_RX) {
/* RX */
@@ -170,7 +172,8 @@ static int poison_channel(struct most_interface *most_iface,
struct hdm_i2c *dev = to_hdm(most_iface);
struct mbo *mbo;
- BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+ if (ch_idx < 0 || ch_idx >= NUM_CHANNELS)
+ return -EINVAL;
if (ch_idx == CH_RX) {
if (!polling_rate)
--
2.51.1