From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
SM6150 uses the same DisplayPort controller as SM8150, which is already
compatible with SM8350. Add the SM6150-specific compatible string and
update the binding example accordingly.
Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
---
.../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
index 9ac24f99d3ada1c197c9654dc9babebccae972ed..89852af70de97a9025079107b838de578778c049 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
@@ -51,6 +51,16 @@ patternProperties:
compatible:
const: qcom,sm6150-dpu
+ "^displayport-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ items:
+ - const: qcom,sm6150-dp
+ - const: qcom,sm8150-dp
+ - const: qcom,sm8350-dp
+
"^dsi@[0-9a-f]+$":
type: object
additionalProperties: true
@@ -132,13 +142,14 @@ examples:
port@0 {
reg = <0>;
dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss_dp0_in>;
};
};
port@1 {
reg = <1>;
dpu_intf1_out: endpoint {
- remote-endpoint = <&mdss_dsi0_in>;
+ remote-endpoint = <&mdss_dsi0_in>;
};
};
};
--
2.34.1On Tue, Oct 21, 2025 at 11:18:07AM +0800, Xiangxu Yin via B4 Relay wrote:
> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>
> SM6150 uses the same DisplayPort controller as SM8150, which is already
> compatible with SM8350. Add the SM6150-specific compatible string and
> update the binding example accordingly.
>
> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
> ---
> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..89852af70de97a9025079107b838de578778c049 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
> @@ -51,6 +51,16 @@ patternProperties:
> compatible:
> const: qcom,sm6150-dpu
>
> + "^displayport-controller@[0-9a-f]+$":
> + type: object
> + additionalProperties: true
> + properties:
> + compatible:
> + items:
> + - const: qcom,sm6150-dp
> + - const: qcom,sm8150-dp
> + - const: qcom,sm8350-dp
> +
> "^dsi@[0-9a-f]+$":
> type: object
> additionalProperties: true
> @@ -132,13 +142,14 @@ examples:
> port@0 {
> reg = <0>;
> dpu_intf0_out: endpoint {
> + remote-endpoint = <&mdss_dp0_in>;
Why?
> };
> };
>
> port@1 {
> reg = <1>;
> dpu_intf1_out: endpoint {
> - remote-endpoint = <&mdss_dsi0_in>;
> + remote-endpoint = <&mdss_dsi0_in>;
Why?
> };
> };
> };
>
> --
> 2.34.1
>
>
--
With best wishes
Dmitry
On 10/22/2025 11:07 PM, Dmitry Baryshkov wrote:
> On Tue, Oct 21, 2025 at 11:18:07AM +0800, Xiangxu Yin via B4 Relay wrote:
>> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>>
>> SM6150 uses the same DisplayPort controller as SM8150, which is already
>> compatible with SM8350. Add the SM6150-specific compatible string and
>> update the binding example accordingly.
>>
>> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..89852af70de97a9025079107b838de578778c049 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>> @@ -51,6 +51,16 @@ patternProperties:
>> compatible:
>> const: qcom,sm6150-dpu
>>
>> + "^displayport-controller@[0-9a-f]+$":
>> + type: object
>> + additionalProperties: true
>> + properties:
>> + compatible:
>> + items:
>> + - const: qcom,sm6150-dp
>> + - const: qcom,sm8150-dp
>> + - const: qcom,sm8350-dp
>> +
>> "^dsi@[0-9a-f]+$":
>> type: object
>> additionalProperties: true
>> @@ -132,13 +142,14 @@ examples:
>> port@0 {
>> reg = <0>;
>> dpu_intf0_out: endpoint {
>> + remote-endpoint = <&mdss_dp0_in>;
> Why?
Oh, I think I misunderstood the “messed up indentation” comment from Krzysztof.
It seems the two-space indentation under port@X and opp-x is the actual issue.
However, that part was not introduced in this patch.
I will split a separate patch to fix the indentation there.
>> };
>> };
>>
>> port@1 {
>> reg = <1>;
>> dpu_intf1_out: endpoint {
>> - remote-endpoint = <&mdss_dsi0_in>;
>> + remote-endpoint = <&mdss_dsi0_in>;
> Why?
Ack.
>> };
>> };
>> };
>>
>> --
>> 2.34.1
>>
>>
On 23/10/2025 07:50, Xiangxu Yin wrote:
>
> On 10/22/2025 11:07 PM, Dmitry Baryshkov wrote:
>> On Tue, Oct 21, 2025 at 11:18:07AM +0800, Xiangxu Yin via B4 Relay wrote:
>>> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>>>
>>> SM6150 uses the same DisplayPort controller as SM8150, which is already
>>> compatible with SM8350. Add the SM6150-specific compatible string and
>>> update the binding example accordingly.
>>>
>>> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>>> ---
>>> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 13 ++++++++++++-
>>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>>> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..89852af70de97a9025079107b838de578778c049 100644
>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>>> @@ -51,6 +51,16 @@ patternProperties:
>>> compatible:
>>> const: qcom,sm6150-dpu
>>>
>>> + "^displayport-controller@[0-9a-f]+$":
>>> + type: object
>>> + additionalProperties: true
>>> + properties:
>>> + compatible:
>>> + items:
>>> + - const: qcom,sm6150-dp
>>> + - const: qcom,sm8150-dp
>>> + - const: qcom,sm8350-dp
>>> +
>>> "^dsi@[0-9a-f]+$":
>>> type: object
>>> additionalProperties: true
>>> @@ -132,13 +142,14 @@ examples:
>>> port@0 {
>>> reg = <0>;
>>> dpu_intf0_out: endpoint {
>>> + remote-endpoint = <&mdss_dp0_in>;
>> Why?
>
>
> Oh, I think I misunderstood the “messed up indentation” comment from Krzysztof.
> It seems the two-space indentation under port@X and opp-x is the actual issue.
>
> However, that part was not introduced in this patch.
> I will split a separate patch to fix the indentation there.
Note, you have two different chunks here. The first one is useless as it
adds a graph arc to a node that is not a part of the example.
>
>
>>> };
>>> };
>>>
>>> port@1 {
>>> reg = <1>;
>>> dpu_intf1_out: endpoint {
>>> - remote-endpoint = <&mdss_dsi0_in>;
>>> + remote-endpoint = <&mdss_dsi0_in>;
>> Why?
>
>
> Ack.
Use YAML coding style (two-space indentation). For DTS examples in the
schema, preferred is four-space indentation.
--
With best wishes
Dmitry
On 10/23/2025 1:10 PM, Dmitry Baryshkov wrote:
> On 23/10/2025 07:50, Xiangxu Yin wrote:
>>
>> On 10/22/2025 11:07 PM, Dmitry Baryshkov wrote:
>>> On Tue, Oct 21, 2025 at 11:18:07AM +0800, Xiangxu Yin via B4 Relay wrote:
>>>> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>>>>
>>>> SM6150 uses the same DisplayPort controller as SM8150, which is already
>>>> compatible with SM8350. Add the SM6150-specific compatible string and
>>>> update the binding example accordingly.
>>>>
>>>> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>>>> ---
>>>> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 13 ++++++++++++-
>>>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>>>> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..89852af70de97a9025079107b838de578778c049 100644
>>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
>>>> @@ -51,6 +51,16 @@ patternProperties:
>>>> compatible:
>>>> const: qcom,sm6150-dpu
>>>> + "^displayport-controller@[0-9a-f]+$":
>>>> + type: object
>>>> + additionalProperties: true
>>>> + properties:
>>>> + compatible:
>>>> + items:
>>>> + - const: qcom,sm6150-dp
>>>> + - const: qcom,sm8150-dp
>>>> + - const: qcom,sm8350-dp
>>>> +
>>>> "^dsi@[0-9a-f]+$":
>>>> type: object
>>>> additionalProperties: true
>>>> @@ -132,13 +142,14 @@ examples:
>>>> port@0 {
>>>> reg = <0>;
>>>> dpu_intf0_out: endpoint {
>>>> + remote-endpoint = <&mdss_dp0_in>;
>>> Why?
>>
>>
>> Oh, I think I misunderstood the “messed up indentation” comment from Krzysztof.
>> It seems the two-space indentation under port@X and opp-x is the actual issue.
>>
>> However, that part was not introduced in this patch.
>> I will split a separate patch to fix the indentation there.
>
> Note, you have two different chunks here. The first one is useless as it adds a graph arc to a node that is not a part of the example.
>
You’re right, I verified with CHECK_DTBS and it passes without it,
so I’ll drop it in the next version.
>>
>>
>>>> };
>>>> };
>>>> port@1 {
>>>> reg = <1>;
>>>> dpu_intf1_out: endpoint {
>>>> - remote-endpoint = <&mdss_dsi0_in>;
>>>> + remote-endpoint = <&mdss_dsi0_in>;
>>> Why?
>>
>>
>> Ack.
>
> Use YAML coding style (two-space indentation). For DTS examples in the schema, preferred is four-space indentation.
>
Ok, will add a new subpatch to fix DTS example indentation.
© 2016 - 2026 Red Hat, Inc.