[PATCH] mtd: rawnand: realtek: Make rtl_ecc_engine_ops const

Li Qiang posted 1 patch 3 months, 2 weeks ago
drivers/mtd/nand/ecc-realtek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] mtd: rawnand: realtek: Make rtl_ecc_engine_ops const
Posted by Li Qiang 3 months, 2 weeks ago
The rtl_ecc_engine_ops structure is only used to provide a set of
callback functions and is never modified after initialization.
Mark it as const so it can be placed in the read-only section, which
improves safety and allows better compiler optimization.

Signed-off-by: Li Qiang <liqiang01@kylinos.cn>
---
 drivers/mtd/nand/ecc-realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/ecc-realtek.c b/drivers/mtd/nand/ecc-realtek.c
index 7d718934c909..32da4c15fbe9 100644
--- a/drivers/mtd/nand/ecc-realtek.c
+++ b/drivers/mtd/nand/ecc-realtek.c
@@ -380,7 +380,7 @@ static void rtl_ecc_cleanup_ctx(struct nand_device *nand)
 		nand_ecc_cleanup_req_tweaking(&ctx->req_ctx);
 }
 
-static struct nand_ecc_engine_ops rtl_ecc_engine_ops = {
+static const struct nand_ecc_engine_ops rtl_ecc_engine_ops = {
 	.init_ctx = rtl_ecc_init_ctx,
 	.cleanup_ctx = rtl_ecc_cleanup_ctx,
 	.prepare_io_req = rtl_ecc_prepare_io_req,
-- 
2.25.1
Re: [PATCH] mtd: rawnand: realtek: Make rtl_ecc_engine_ops const
Posted by Miquel Raynal 3 months, 2 weeks ago
On Mon, 20 Oct 2025 20:53:33 +0800, Li Qiang wrote:
> The rtl_ecc_engine_ops structure is only used to provide a set of
> callback functions and is never modified after initialization.
> Mark it as const so it can be placed in the read-only section, which
> improves safety and allows better compiler optimization.
> 
> 

Applied to mtd/fixes, thanks!

[1/1] mtd: rawnand: realtek: Make rtl_ecc_engine_ops const
      commit: 9631350885929819d4e46c6521df35960b472ef3

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl