[PATCH] gpio: qixis-fpga: add missing module description

Bartosz Golaszewski posted 1 patch 3 months, 2 weeks ago
drivers/gpio/gpio-qixis-fpga.c | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] gpio: qixis-fpga: add missing module description
Posted by Bartosz Golaszewski 3 months, 2 weeks ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

A kernel module must have a license and should have a description. Add
missing MODULE_LICENSE(), MODULE_DESCRIPTION() and throw in a
MODULE_AUTHOR() for good measure.

This fixes the following build issues:

ERROR: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-qixis-fpga.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpio/gpio-qixis-fpga.o

Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/aPJW8HIke5pj3doX@sirena.org.uk/
Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-qixis-fpga.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpio/gpio-qixis-fpga.c b/drivers/gpio/gpio-qixis-fpga.c
index 048a2cac4f0f..54c2c76822d5 100644
--- a/drivers/gpio/gpio-qixis-fpga.c
+++ b/drivers/gpio/gpio-qixis-fpga.c
@@ -105,3 +105,7 @@ static struct platform_driver qixis_cpld_gpio_driver = {
 	},
 };
 module_platform_driver(qixis_cpld_gpio_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Ioana Ciornei <ioana.ciornei@nxp.com>");
+MODULE_DESCRIPTION("Layerscape GPIO QIXIS FPGA driver");
-- 
2.48.1
Re: [PATCH] gpio: qixis-fpga: add missing module description
Posted by Ioana Ciornei 3 months, 2 weeks ago
On Mon, Oct 20, 2025 at 09:20:28AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> A kernel module must have a license and should have a description. Add
> missing MODULE_LICENSE(), MODULE_DESCRIPTION() and throw in a
> MODULE_AUTHOR() for good measure.
> 
> This fixes the following build issues:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-qixis-fpga.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpio/gpio-qixis-fpga.o
>

I am extremely sorry that I was not able to send this patch myself. I
just got back from some days off.

Thank you for handling this.

Ioana
Re: [PATCH] gpio: qixis-fpga: add missing module description
Posted by Bartosz Golaszewski 3 months, 2 weeks ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 20 Oct 2025 09:20:28 +0200, Bartosz Golaszewski wrote:
> A kernel module must have a license and should have a description. Add
> missing MODULE_LICENSE(), MODULE_DESCRIPTION() and throw in a
> MODULE_AUTHOR() for good measure.
> 
> This fixes the following build issues:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-qixis-fpga.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpio/gpio-qixis-fpga.o
> 
> [...]

Applied, thanks!

[1/1] gpio: qixis-fpga: add missing module description
      https://git.kernel.org/brgl/linux/c/e0a6ec724e5b87a0b162912b5d30bb6f066677e2

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>