dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range

[PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range

Posted by Ryan Chen 3 months, 2 weeks ago

The #size-cells property in the Aspeed SCU binding is currently
fixed to a constant value of 1. However, newer SoCs (ex. AST2700)
may require two size cells to describe certain subregions or
subdevices.

This patch updates the schema to allow #size-cells values in
the range of 1 to 2. This makes the binding more flexible
while maintaining compatibility with existing platforms.
It also resolves dt-binding validation warnings reported
by `make dt_binding_check`.

Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
---
 Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
index 5eccd10d95ce..1d3f686577db 100644
--- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
+++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
@@ -38,7 +38,8 @@ properties:
     maximum: 2
 
   '#size-cells':
-    const: 1
+    minimum: 1
+    maximum: 2
 
   '#clock-cells':
     const: 1
-- 
2.34.1

Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range

Posted by Krzysztof Kozlowski 3 months, 2 weeks ago

On 20/10/2025 04:07, Ryan Chen wrote:
> The #size-cells property in the Aspeed SCU binding is currently
> fixed to a constant value of 1. However, newer SoCs (ex. AST2700)
> may require two size cells to describe certain subregions or

"may"? So there is no issue yet?

> subdevices.
> 
> This patch updates the schema to allow #size-cells values in
> the range of 1 to 2. This makes the binding more flexible
> while maintaining compatibility with existing platforms.
> It also resolves dt-binding validation warnings reported
> by `make dt_binding_check`.

Bu there is a warning? Which warning? On which file?

> 
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> index 5eccd10d95ce..1d3f686577db 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> @@ -38,7 +38,8 @@ properties:
>      maximum: 2
>  
>    '#size-cells':
> -    const: 1
> +    minimum: 1
> +    maximum: 2

That's just enum.

>  
>    '#clock-cells':
>      const: 1


Best regards,
Krzysztof