[PATCH 0/2] riscv: tests: Make RISCV_KPROBES_KUNIT tristate

Vivian Wang posted 2 patches 3 months, 3 weeks ago
arch/riscv/kernel/tests/Kconfig.debug          | 2 +-
arch/riscv/kernel/tests/kprobes/Makefile       | 4 +++-
arch/riscv/kernel/tests/kprobes/test-kprobes.c | 5 ++++-
3 files changed, 8 insertions(+), 3 deletions(-)
[PATCH 0/2] riscv: tests: Make RISCV_KPROBES_KUNIT tristate
Posted by Vivian Wang 3 months, 3 weeks ago
Fix an allmodconfig warning on v6.18-rc1:

    WARNING: 3 bad relocations
    ffffffff81e24118 R_RISCV_64        kunit_unary_assert_format
    ffffffff81e24a60 R_RISCV_64        kunit_binary_assert_format
    ffffffff81e269d0 R_RISCV_JUMP_SLOT  __kunit_do_failed_assertion

While we're at it, rename the test to remove the word "test", in order
to conform to the style guide.

---
Vivian Wang (2):
      riscv: tests: Rename kprobes_test_riscv to kprobes_riscv
      riscv: tests: Make RISCV_KPROBES_KUNIT tristate

 arch/riscv/kernel/tests/Kconfig.debug          | 2 +-
 arch/riscv/kernel/tests/kprobes/Makefile       | 4 +++-
 arch/riscv/kernel/tests/kprobes/test-kprobes.c | 5 ++++-
 3 files changed, 8 insertions(+), 3 deletions(-)
---
base-commit: cb6649f6217c0331b885cf787f1d175963e2a1d2
change-id: 20251020-riscv-kunit-kconfig-fix-6-18-01fc6eba6613

Best regards,
-- 
Vivian "dramforever" Wang
Re: [PATCH 0/2] riscv: tests: Make RISCV_KPROBES_KUNIT tristate
Posted by Inochi Amaoto 3 months, 2 weeks ago
On Mon, Oct 20, 2025 at 08:23:54PM +0800, Vivian Wang wrote:
> Fix an allmodconfig warning on v6.18-rc1:
> 
>     WARNING: 3 bad relocations
>     ffffffff81e24118 R_RISCV_64        kunit_unary_assert_format
>     ffffffff81e24a60 R_RISCV_64        kunit_binary_assert_format
>     ffffffff81e269d0 R_RISCV_JUMP_SLOT  __kunit_do_failed_assertion
> 
> While we're at it, rename the test to remove the word "test", in order
> to conform to the style guide.
> 
> ---
> Vivian Wang (2):
>       riscv: tests: Rename kprobes_test_riscv to kprobes_riscv
>       riscv: tests: Make RISCV_KPROBES_KUNIT tristate
> 
>  arch/riscv/kernel/tests/Kconfig.debug          | 2 +-
>  arch/riscv/kernel/tests/kprobes/Makefile       | 4 +++-
>  arch/riscv/kernel/tests/kprobes/test-kprobes.c | 5 ++++-
>  3 files changed, 8 insertions(+), 3 deletions(-)
> ---
> base-commit: cb6649f6217c0331b885cf787f1d175963e2a1d2
> change-id: 20251020-riscv-kunit-kconfig-fix-6-18-01fc6eba6613
> 
> Best regards,
> -- 
> Vivian "dramforever" Wang
> 

Tested with allmodconfig

Tested-by: Inochi Amaoto <inochiama@gmail.com>
Re: [PATCH 0/2] riscv: tests: Make RISCV_KPROBES_KUNIT tristate
Posted by Nam Cao 3 months, 2 weeks ago
Vivian Wang <wangruikang@iscas.ac.cn> writes:
> Fix an allmodconfig warning on v6.18-rc1:
>
>     WARNING: 3 bad relocations
>     ffffffff81e24118 R_RISCV_64        kunit_unary_assert_format
>     ffffffff81e24a60 R_RISCV_64        kunit_binary_assert_format
>     ffffffff81e269d0 R_RISCV_JUMP_SLOT  __kunit_do_failed_assertion
>
> While we're at it, rename the test to remove the word "test", in order
> to conform to the style guide.

Reviewed-by: Nam Cao <namcao@linutronix.de>
Re: [PATCH 0/2] riscv: tests: Make RISCV_KPROBES_KUNIT tristate
Posted by Vivian Wang 3 months, 3 weeks ago
On 10/20/25 20:23, Vivian Wang wrote:

> Fix an allmodconfig warning on v6.18-rc1:
>
>     WARNING: 3 bad relocations
>     ffffffff81e24118 R_RISCV_64        kunit_unary_assert_format
>     ffffffff81e24a60 R_RISCV_64        kunit_binary_assert_format
>     ffffffff81e269d0 R_RISCV_JUMP_SLOT  __kunit_do_failed_assertion

For more context, I said this was to fix a warning, but I tried it out
anyway just to see what happens. Apparently, nothing. The kprobe tests
just don't run if RISCV_KPROBES_KUNIT=y but KUNIT=m.

So this config combination being just wrong is the problem, and the
warning is just a loud symptom.

Vivian "dramforever" Wang