media: renesas: fdp1: Use %pe format specifier

[PATCH] media: renesas: fdp1: Use %pe format specifier

Posted by Ricardo Ribalda 3 months, 3 weeks ago

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR()

This patch fixes this cocci report:
./platform/renesas/rcar_fdp1.c:2303:4-11: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
It seems that we missed this file from the original patchset.
https://lore.kernel.org/linux-media/20251013-ptr_err-v1-0-2c5efbd82952@chromium.org/
---
 drivers/media/platform/renesas/rcar_fdp1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
index 3515601030eccefe3d979303893c93c85ab0a9b2..672869815f636de25ce08261bf327f156b617a37 100644
--- a/drivers/media/platform/renesas/rcar_fdp1.c
+++ b/drivers/media/platform/renesas/rcar_fdp1.c
@@ -2299,8 +2299,7 @@ static int fdp1_probe(struct platform_device *pdev)
 		fdp1->fcp = rcar_fcp_get(fcp_node);
 		of_node_put(fcp_node);
 		if (IS_ERR(fdp1->fcp)) {
-			dev_dbg(&pdev->dev, "FCP not found (%ld)\n",
-				PTR_ERR(fdp1->fcp));
+			dev_dbg(&pdev->dev, "FCP not found (%pe)\n", fdp1->fcp);
 			return PTR_ERR(fdp1->fcp);
 		}
 	}

---
base-commit: 8652359fc004cbadbf0e95692c1472caac6260c2
change-id: 20251020-ptr_err-leftover-1997b3a6e06e

Best regards,
-- 
Ricardo Ribalda <ribalda@chromium.org>

Re: [PATCH] media: renesas: fdp1: Use %pe format specifier

Posted by Kieran Bingham 3 months, 3 weeks ago

Quoting Ricardo Ribalda (2025-10-20 08:53:41)
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR()
> 
> This patch fixes this cocci report:
> ./platform/renesas/rcar_fdp1.c:2303:4-11: WARNING: Consider using %pe to print PTR_ERR()
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Thanks, same as the others:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
> It seems that we missed this file from the original patchset.
> https://lore.kernel.org/linux-media/20251013-ptr_err-v1-0-2c5efbd82952@chromium.org/
> ---
>  drivers/media/platform/renesas/rcar_fdp1.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
> index 3515601030eccefe3d979303893c93c85ab0a9b2..672869815f636de25ce08261bf327f156b617a37 100644
> --- a/drivers/media/platform/renesas/rcar_fdp1.c
> +++ b/drivers/media/platform/renesas/rcar_fdp1.c
> @@ -2299,8 +2299,7 @@ static int fdp1_probe(struct platform_device *pdev)
>                 fdp1->fcp = rcar_fcp_get(fcp_node);
>                 of_node_put(fcp_node);
>                 if (IS_ERR(fdp1->fcp)) {
> -                       dev_dbg(&pdev->dev, "FCP not found (%ld)\n",
> -                               PTR_ERR(fdp1->fcp));
> +                       dev_dbg(&pdev->dev, "FCP not found (%pe)\n", fdp1->fcp);
>                         return PTR_ERR(fdp1->fcp);
>                 }
>         }
> 
> ---
> base-commit: 8652359fc004cbadbf0e95692c1472caac6260c2
> change-id: 20251020-ptr_err-leftover-1997b3a6e06e
> 
> Best regards,
> -- 
> Ricardo Ribalda <ribalda@chromium.org>
>

Re: [PATCH] media: renesas: fdp1: Use %pe format specifier

Posted by Hans Verkuil 3 months, 3 weeks ago

On 20/10/2025 09:57, Kieran Bingham wrote:
> Quoting Ricardo Ribalda (2025-10-20 08:53:41)
>> The %pe format specifier is designed to print error pointers. It prints
>> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
>> omitting PTR_ERR()
>>
>> This patch fixes this cocci report:
>> ./platform/renesas/rcar_fdp1.c:2303:4-11: WARNING: Consider using %pe to print PTR_ERR()
>>
>> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> 
> Thanks, same as the others:
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

I'll try to fast-track this patch today. It's good to get this all in.

Regards,

	Hans

> 
>> ---
>> It seems that we missed this file from the original patchset.
>> https://lore.kernel.org/linux-media/20251013-ptr_err-v1-0-2c5efbd82952@chromium.org/
>> ---
>>  drivers/media/platform/renesas/rcar_fdp1.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
>> index 3515601030eccefe3d979303893c93c85ab0a9b2..672869815f636de25ce08261bf327f156b617a37 100644
>> --- a/drivers/media/platform/renesas/rcar_fdp1.c
>> +++ b/drivers/media/platform/renesas/rcar_fdp1.c
>> @@ -2299,8 +2299,7 @@ static int fdp1_probe(struct platform_device *pdev)
>>                 fdp1->fcp = rcar_fcp_get(fcp_node);
>>                 of_node_put(fcp_node);
>>                 if (IS_ERR(fdp1->fcp)) {
>> -                       dev_dbg(&pdev->dev, "FCP not found (%ld)\n",
>> -                               PTR_ERR(fdp1->fcp));
>> +                       dev_dbg(&pdev->dev, "FCP not found (%pe)\n", fdp1->fcp);
>>                         return PTR_ERR(fdp1->fcp);
>>                 }
>>         }
>>
>> ---
>> base-commit: 8652359fc004cbadbf0e95692c1472caac6260c2
>> change-id: 20251020-ptr_err-leftover-1997b3a6e06e
>>
>> Best regards,
>> -- 
>> Ricardo Ribalda <ribalda@chromium.org>
>>
>