[PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

Krzysztof Kozlowski posted 3 patches 3 months, 3 weeks ago
[PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema
Posted by Krzysztof Kozlowski 3 months, 3 weeks ago
The parent node of ROHM BD96801 PMIC is also holding properties for the
watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
timeout-sec property is used only as one number.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

This depends on previous watchdog patch.  I propose to take entire set
via watchdog tree, with Lee's acks.
---
 Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
index 0e06570483ae..adb491bcc8dc 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
@@ -57,8 +57,7 @@ properties:
       - prstb
       - intb-only
 
-  timeout-sec:
-    maxItems: 2
+  timeout-sec: true
 
   regulators:
     $ref: /schemas/regulator/rohm,bd96801-regulator.yaml
@@ -72,7 +71,10 @@ required:
   - interrupt-names
   - regulators
 
-additionalProperties: false
+allOf:
+  - $ref: /schemas/watchdog/watchdog.yaml
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.48.1
Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema
Posted by Lee Jones 3 months ago
On Mon, 20 Oct 2025, Krzysztof Kozlowski wrote:

> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> This depends on previous watchdog patch.  I propose to take entire set
> via watchdog tree, with Lee's acks.

Sure.

Acked-by: Lee Jones <lee@kernel.org>

-- 
Lee Jones [李琼斯]
Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema
Posted by Rob Herring (Arm) 3 months, 2 weeks ago
On Mon, 20 Oct 2025 18:52:22 +0200, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> This depends on previous watchdog patch.  I propose to take entire set
> via watchdog tree, with Lee's acks.
> ---
>  Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema
Posted by Matti Vaittinen 3 months, 2 weeks ago
Thanks Krzysztof!

On 20/10/2025 19:52, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema
Posted by Guenter Roeck 3 months, 3 weeks ago
On 10/20/25 09:52, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> 
> ---
> 
> This depends on previous watchdog patch.  I propose to take entire set
> via watchdog tree, with Lee's acks.
> ---
>   Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> index 0e06570483ae..adb491bcc8dc 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> @@ -57,8 +57,7 @@ properties:
>         - prstb
>         - intb-only
>   
> -  timeout-sec:
> -    maxItems: 2
> +  timeout-sec: true
>   
>     regulators:
>       $ref: /schemas/regulator/rohm,bd96801-regulator.yaml
> @@ -72,7 +71,10 @@ required:
>     - interrupt-names
>     - regulators
>   
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/watchdog/watchdog.yaml
> +
> +unevaluatedProperties: false
>   
>   examples:
>     - |
>