ata: Replace deprecated strcpy with strscpy in it821x_display_disk

[PATCH] ata: Replace deprecated strcpy with strscpy in it821x_display_disk

Posted by Thorsten Blum 3 months, 3 weeks ago

strcpy() is deprecated; use strscpy() instead.

Replace the hard-coded buffer size 8 with sizeof(mbuf) when using
snprintf() while we're at it.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/ata/pata_it821x.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
index 042f6ad1f7c6..fc762dcc61bf 100644
--- a/drivers/ata/pata_it821x.c
+++ b/drivers/ata/pata_it821x.c
@@ -75,6 +75,7 @@
 #include <linux/blkdev.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 #include <scsi/scsi_host.h>
 #include <linux/libata.h>
 
@@ -632,9 +633,9 @@ static void it821x_display_disk(struct ata_port *ap, int n, u8 *buf)
 		cbl = "";
 
 	if (mode)
-		snprintf(mbuf, 8, "%5s%d", mtype, mode - 1);
+		snprintf(mbuf, sizeof(mbuf), "%5s%d", mtype, mode - 1);
 	else
-		strcpy(mbuf, "PIO");
+		strscpy(mbuf, "PIO");
 	if (buf[52] == 4)
 		ata_port_info(ap, "%d: %-6s %-8s          %s %s\n",
 				n, mbuf, types[buf[52]], id, cbl);
-- 
2.51.0

Re: [PATCH] ata: Replace deprecated strcpy with strscpy in it821x_display_disk

Posted by Niklas Cassel 3 months, 2 weeks ago

On Sat, Oct 18, 2025 at 12:51:45PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> Replace the hard-coded buffer size 8 with sizeof(mbuf) when using
> snprintf() while we're at it.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Applied, thank you!

https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/commit/?h=for-6.19&id=4ea303d9e9862ff8bd3707f67b267646b8ffd3ec

Re: [PATCH] ata: Replace deprecated strcpy with strscpy in it821x_display_disk

Posted by Damien Le Moal 3 months, 2 weeks ago

On 10/18/25 19:51, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> Replace the hard-coded buffer size 8 with sizeof(mbuf) when using
> snprintf() while we're at it.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Note: the patch title should be:

ata: pata_it821x: Replace deprecated strcpy with strscpy in it821x_display_disk

Niklas can fix that when applying I think.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research