On Sat, Oct 18, 2025 at 04:01:02AM +0200, Louis Chauvet wrote:
> Use directory name as name for the plane.
>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> drivers/gpu/drm/vkms/vkms_configfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c
> index 07ab794e1052..ea245e2e2fd2 100644
> --- a/drivers/gpu/drm/vkms/vkms_configfs.c
> +++ b/drivers/gpu/drm/vkms/vkms_configfs.c
> @@ -376,6 +376,7 @@ static struct config_group *make_plane_group(struct config_group *group,
> kfree(plane);
> return ERR_CAST(plane->config);
> }
> + vkms_config_plane_set_name(plane->config, name);
Could this break the UAPI?
Until now, the name was NULL. In __drm_universal_plane_init(), when the name
is not set, "plane-%d" is used to compose its name.
Therefore, if we now use the directory name as the plane name, we are changing
a bit how VKMS behaves.
It is not a big deal, but I think that a "name" file could be a safer approach.
Jose
> config_group_init_type_name(&plane->group, name, &plane_item_type);
>
>
> --
> 2.51.0
>