[v1] Add SDM660 cDSP support

[PATCH 1/2] dt-bindings: remoteproc: qcom: adsp: Add SDM660 CDSP compatible

Posted by Nickolay Goppen 3 months, 3 weeks ago

Add compatible for the compute DSP remoteproc found in SDM660.

Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 661c2b425da3..19d16c97d8a4 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -24,6 +24,7 @@ properties:
       - qcom,msm8998-adsp-pas
       - qcom,msm8998-slpi-pas
       - qcom,sdm660-adsp-pas
+      - qcom,sdm660-cdsp-pas
       - qcom,sdm845-adsp-pas
       - qcom,sdm845-cdsp-pas
       - qcom,sdm845-slpi-pas
@@ -178,6 +179,7 @@ allOf:
               - qcom,msm8998-adsp-pas
               - qcom,msm8998-slpi-pas
               - qcom,sdm660-adsp-pas
+              - qcom,sdm660-cdsp-pas
     then:
       properties:
         qcom,qmp: false

-- 
2.51.1

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: adsp: Add SDM660 CDSP compatible

Posted by Krzysztof Kozlowski 3 months, 3 weeks ago

On 18/10/2025 12:57, Nickolay Goppen wrote:
> Add compatible for the compute DSP remoteproc found in SDM660.
> 
> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 661c2b425da3..19d16c97d8a4 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -24,6 +24,7 @@ properties:
>        - qcom,msm8998-adsp-pas
>        - qcom,msm8998-slpi-pas
>        - qcom,sdm660-adsp-pas
> +      - qcom,sdm660-cdsp-pas
>        - qcom,sdm845-adsp-pas
>        - qcom,sdm845-cdsp-pas
>        - qcom,sdm845-slpi-pas
> @@ -178,6 +179,7 @@ allOf:
>                - qcom,msm8998-adsp-pas
>                - qcom,msm8998-slpi-pas
>                - qcom,sdm660-adsp-pas

Where is the constrain for everything else? clocks, interrupts and domains?

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: adsp: Add SDM660 CDSP compatible

Posted by Nickolay Goppen 3 months, 3 weeks ago

18.10.2025 18:42, Krzysztof Kozlowski пишет:
> On 18/10/2025 12:57, Nickolay Goppen wrote:
>> Add compatible for the compute DSP remoteproc found in SDM660.
>>
>> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
>> ---
>>   Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> index 661c2b425da3..19d16c97d8a4 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> @@ -24,6 +24,7 @@ properties:
>>         - qcom,msm8998-adsp-pas
>>         - qcom,msm8998-slpi-pas
>>         - qcom,sdm660-adsp-pas
>> +      - qcom,sdm660-cdsp-pas
>>         - qcom,sdm845-adsp-pas
>>         - qcom,sdm845-cdsp-pas
>>         - qcom,sdm845-slpi-pas
>> @@ -178,6 +179,7 @@ allOf:
>>                 - qcom,msm8998-adsp-pas
>>                 - qcom,msm8998-slpi-pas
>>                 - qcom,sdm660-adsp-pas
> Where is the constrain for everything else? clocks, interrupts and domains?
I think that cDSP and aDSP compatible should be both added to the "xo" 
clock, interrupts and "cx" power-domain constrains, but I'm not sure 
about that.
> Best regards,
> Krzysztof

-- 
Best regards,
Nickolay