[v4] Add support for Cirrus Logic CS530x DAC and CODEC variants.

[PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants

Posted by Vitaly Rodionov 3 months, 3 weeks ago

This patch adds additional cs530x family variants.

cirrus,cs4282 - high-performance, 32-bit resolution, stereo CODEC
cirrus,cs4302 - high performance stereo DAC, 2 channels
cirrus,cs4304 - high performance stereo DAC, 4 channels
cirrus,cs4308 - high performance stereo DAC, 8 channels

Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
---
 Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
index 9582eb8eb418..90a5cea0632d 100644
--- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
+++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
@@ -22,6 +22,10 @@ properties:
       - cirrus,cs5302
       - cirrus,cs5304
       - cirrus,cs5308
+      - cirrus,cs4282
+      - cirrus,cs4302
+      - cirrus,cs4304
+      - cirrus,cs4308
 
   reg:
     maxItems: 1
-- 
2.43.0

Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants

Posted by Krzysztof Kozlowski 3 months, 3 weeks ago

On 17/10/2025 18:15, Vitaly Rodionov wrote:
> This patch adds additional cs530x family variants.
> 
> cirrus,cs4282 - high-performance, 32-bit resolution, stereo CODEC
> cirrus,cs4302 - high performance stereo DAC, 2 channels
> cirrus,cs4304 - high performance stereo DAC, 4 channels
> cirrus,cs4308 - high performance stereo DAC, 8 channels
> 
> Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
> ---
>  Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> index 9582eb8eb418..90a5cea0632d 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> @@ -22,6 +22,10 @@ properties:
>        - cirrus,cs5302
>        - cirrus,cs5304
>        - cirrus,cs5308
> +      - cirrus,cs4282
> +      - cirrus,cs4302
> +      - cirrus,cs4304
> +      - cirrus,cs4308

I asked about fixing this at v1. You ignored it. Then I reminded this at
v3. You sent v4 still ignoring my comment.

I don't know what to do more.

NAK

Best regards,
Krzysztof

Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants

Posted by Vitaly Rodionov 3 months, 3 weeks ago

On Sun, Oct 19, 2025 at 12:32:20PM +0200, Krzysztof Kozlowski wrote:
> On 17/10/2025 18:15, Vitaly Rodionov wrote:
> > This patch adds additional cs530x family variants.
> > 
> > cirrus,cs4282 - high-performance, 32-bit resolution, stereo CODEC
> > cirrus,cs4302 - high performance stereo DAC, 2 channels
> > cirrus,cs4304 - high performance stereo DAC, 4 channels
> > cirrus,cs4308 - high performance stereo DAC, 8 channels
> > 
> > Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
> > ---
> >  Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > index 9582eb8eb418..90a5cea0632d 100644
> > --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > @@ -22,6 +22,10 @@ properties:
> >        - cirrus,cs5302
> >        - cirrus,cs5304
> >        - cirrus,cs5308
> > +      - cirrus,cs4282
> > +      - cirrus,cs4302
> > +      - cirrus,cs4304
> > +      - cirrus,cs4308
> 
> I asked about fixing this at v1. You ignored it. Then I reminded this at
> v3. You sent v4 still ignoring my comment.
> 
> I don't know what to do more.
> 
> NAK
> 
> Best regards,
> Krzysztof

I’m sorry, Krzysztof — I didn’t ignore your comments. I carefully read the suggested documentation regarding docs and DTS submissions.
My mistake was that I simply missed the point about sorting the string list, and I’ve already acknowledged that in my earlier reply.
Apologies for the confusion — it wasn’t intentional or out of disregard on my part.

Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants

Posted by Mark Brown 3 months, 3 weeks ago

On Fri, Oct 17, 2025 at 05:15:33PM +0100, Vitaly Rodionov wrote:

> --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> @@ -22,6 +22,10 @@ properties:
>        - cirrus,cs5302
>        - cirrus,cs5304
>        - cirrus,cs5308
> +      - cirrus,cs4282
> +      - cirrus,cs4302
> +      - cirrus,cs4304
> +      - cirrus,cs4308

I've not gone back and cheked but I suspect Krzysztof's complaint on
prior versions that he wasn't happy you weren't addressing was that
these enumerations should be sorted.

Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants

Posted by Vitaly Rodionov 3 months, 3 weeks ago

On Fri, Oct 17, 2025 at 05:31:14PM +0100, Mark Brown wrote:
> On Fri, Oct 17, 2025 at 05:15:33PM +0100, Vitaly Rodionov wrote:
> 
> > --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > @@ -22,6 +22,10 @@ properties:
> >        - cirrus,cs5302
> >        - cirrus,cs5304
> >        - cirrus,cs5308
> > +      - cirrus,cs4282
> > +      - cirrus,cs4302
> > +      - cirrus,cs4304
> > +      - cirrus,cs4308
> 
> I've not gone back and cheked but I suspect Krzysztof's complaint on
> prior versions that he wasn't happy you weren't addressing was that
> these enumerations should be sorted.

Sorry, it looks like my email clent decided to send HTML somehow.
Yes, I missed the point about sorted listi again. Will address in the next
version.

Thank you