On Fri, Oct 17, 2025 at 12:09:18PM +0200, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Replace the open coded implementation with the scoped masked user access
> guard.
>
> No functional change intended.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: linux-fsdevel@vger.kernel.org
> ---
> V3: Adopt to scope changes
> ---
> fs/select.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
> ---
> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -776,17 +776,13 @@ static inline int get_sigset_argpack(str
> {
> // the path is hot enough for overhead of copy_from_user() to matter
> if (from) {
> - if (can_do_masked_user_access())
> - from = masked_user_access_begin(from);
> - else if (!user_read_access_begin(from, sizeof(*from)))
> - return -EFAULT;
> - unsafe_get_user(to->p, &from->p, Efault);
> - unsafe_get_user(to->size, &from->size, Efault);
> - user_read_access_end();
> + scoped_masked_user_rw_access(from, Efault) {
Should this not be: scoped_masked_user_read_access() ?
> + unsafe_get_user(to->p, &from->p, Efault);
> + unsafe_get_user(to->size, &from->size, Efault);
> + }
> }
> return 0;
> Efault:
> - user_read_access_end();
> return -EFAULT;
> }
>
>