[PATCH v4 0/3] Add pinctrl support for Sky1

Gary Yang posted 3 patches 3 months, 3 weeks ago
There is a newer version of this series
.../bindings/pinctrl/cix,sky1-pinctrl.yaml    |  94 +++
arch/arm64/boot/dts/cix/sky1-orion-o6.dts     |  32 +
arch/arm64/boot/dts/cix/sky1-pinfunc.h        | 418 +++++++++++++
arch/arm64/boot/dts/cix/sky1.dtsi             |  10 +
drivers/pinctrl/Kconfig                       |   1 +
drivers/pinctrl/Makefile                      |   1 +
drivers/pinctrl/cix/Kconfig                   |  14 +
drivers/pinctrl/cix/Makefile                  |   4 +
drivers/pinctrl/cix/pinctrl-sky1-base.c       | 573 ++++++++++++++++++
drivers/pinctrl/cix/pinctrl-sky1.c            | 559 +++++++++++++++++
drivers/pinctrl/cix/pinctrl-sky1.h            |  48 ++
11 files changed, 1754 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
create mode 100644 arch/arm64/boot/dts/cix/sky1-pinfunc.h
create mode 100644 drivers/pinctrl/cix/Kconfig
create mode 100644 drivers/pinctrl/cix/Makefile
create mode 100644 drivers/pinctrl/cix/pinctrl-sky1-base.c
create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.c
create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.h
[PATCH v4 0/3] Add pinctrl support for Sky1
Posted by Gary Yang 3 months, 3 weeks ago
Patch 1: Add dt-binding doc for pinctrl on Sky1
Patch 2: Add pin-controller driver for sky1
Patch 3: Add pinctrl nodes for sky1

changes for v4:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- support driver_strength = <8> (mA)
- Fix dt-bindings style


Changes for v3:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Re-order the patch set, and move dt-bindings to the 1st patch.
- Refine the pinctrl driver with SKY_PINFUNCTION macro
- Fix warnings when make dt_binding_check

Changes for v2:
- restructure the pinctrl driver to support pinmux=<..>
- redefine pinmux macros
- move header file from dt-bindings to dts
- fix the code-style issues

Gary Yang (3):
  dt-bindings: pinctrl: Add cix,sky1-pinctrl
  pinctrl: cix: Add pin-controller support for sky1
  arm64: dts: cix: Add pinctrl nodes for sky1

 .../bindings/pinctrl/cix,sky1-pinctrl.yaml    |  94 +++
 arch/arm64/boot/dts/cix/sky1-orion-o6.dts     |  32 +
 arch/arm64/boot/dts/cix/sky1-pinfunc.h        | 418 +++++++++++++
 arch/arm64/boot/dts/cix/sky1.dtsi             |  10 +
 drivers/pinctrl/Kconfig                       |   1 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/cix/Kconfig                   |  14 +
 drivers/pinctrl/cix/Makefile                  |   4 +
 drivers/pinctrl/cix/pinctrl-sky1-base.c       | 573 ++++++++++++++++++
 drivers/pinctrl/cix/pinctrl-sky1.c            | 559 +++++++++++++++++
 drivers/pinctrl/cix/pinctrl-sky1.h            |  48 ++
 11 files changed, 1754 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
 create mode 100644 arch/arm64/boot/dts/cix/sky1-pinfunc.h
 create mode 100644 drivers/pinctrl/cix/Kconfig
 create mode 100644 drivers/pinctrl/cix/Makefile
 create mode 100644 drivers/pinctrl/cix/pinctrl-sky1-base.c
 create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.c
 create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.h

-- 
2.49.0
Re: [PATCH v4 0/3] Add pinctrl support for Sky1
Posted by Linus Walleij 3 months, 2 weeks ago
Hi Gary,

overall this version is starting to look really nice!

Please address Conors comments, then see about the
compile error on the driver itself. The code looks good
otherwise.

Looking forward to v5!

Yours,
Linus Walleij