Attempting to load the 104-idio-16 module fails during regmap
initialization with a return error -EINVAL. This is a result of the
regmap cache failing initialization. Set the idio_16_regmap_config
max_register member to fix this failure.

Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
Suggested-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Cc: stable@vger.kernel.org
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
---
 drivers/gpio/gpio-104-idio-16.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c
index ffe7e1cb6b238856b9d13b2a278fe6c44b9cc8d3..fe5c10cd5c327ace1b715e9a27590211dce06fb0 100644
--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -59,6 +59,7 @@ static const struct regmap_config idio_16_regmap_config = {
 	.reg_stride = 1,
 	.val_bits = 8,
 	.io_port = true,
+	.max_register = 0x5,
 	.wr_table = &idio_16_wr_table,
 	.rd_table = &idio_16_rd_table,
 	.volatile_table = &idio_16_rd_table,

-- 
2.51.0

On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> Attempting to load the 104-idio-16 module fails during regmap
> initialization with a return error -EINVAL. This is a result of the
> regmap cache failing initialization. Set the idio_16_regmap_config
> max_register member to fix this failure.

> Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com

Link --> Closes ?

-- 
With Best Regards,
Andy Shevchenko

On Sat, Oct 18, 2025 at 10:00:43PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> > Attempting to load the 104-idio-16 module fails during regmap
> > initialization with a return error -EINVAL. This is a result of the
> > regmap cache failing initialization. Set the idio_16_regmap_config
> > max_register member to fix this failure.
> 
> > Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> > Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> > Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> 
> Link --> Closes ?

So that link points to a report detailing multiple bugs, but this patch
only fixes one of those bugs. Is it still appropriate to use Closes in
this case?

William Breathitt Gray

On Sun, Oct 19, 2025 at 08:44:09AM +0900, William Breathitt Gray wrote:
> On Sat, Oct 18, 2025 at 10:00:43PM +0300, Andy Shevchenko wrote:
> > On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> > > Attempting to load the 104-idio-16 module fails during regmap
> > > initialization with a return error -EINVAL. This is a result of the
> > > regmap cache failing initialization. Set the idio_16_regmap_config
> > > max_register member to fix this failure.
> > 
> > > Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> > > Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> > > Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> > 
> > Link --> Closes ?
> 
> So that link points to a report detailing multiple bugs, but this patch
> only fixes one of those bugs. Is it still appropriate to use Closes in
> this case?

I believe it works in m:n cases, at least I saw in practice several patches
(was a series) were closing the same report.

-- 
With Best Regards,
Andy Shevchenko

On Sat, Oct 18, 2025 at 10:00:44PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> > Attempting to load the 104-idio-16 module fails during regmap
> > initialization with a return error -EINVAL. This is a result of the
> > regmap cache failing initialization. Set the idio_16_regmap_config
> > max_register member to fix this failure.
> 
> > Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> > Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> > Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> 
> Link --> Closes ?

Seems for all patches in the series :-)

-- 
With Best Regards,
Andy Shevchenko