[PATCH 0/2] PCI: dwc: Fix ECAM enablement when used with vendor drivers

Krishna Chaitanya Chundru posted 2 patches 3 months, 3 weeks ago
There is a newer version of this series
drivers/pci/controller/dwc/pcie-designware-host.c | 28 ++++++++--
drivers/pci/controller/dwc/pcie-qcom.c            | 68 -----------------------
2 files changed, 24 insertions(+), 72 deletions(-)
[PATCH 0/2] PCI: dwc: Fix ECAM enablement when used with vendor drivers
Posted by Krishna Chaitanya Chundru 3 months, 3 weeks ago
This series addresses issues with ECAM enablement in the DesignWare PCIe
host controller when used with vendor drivers that rely on the DBI base
for internal accesses.

The first patch fixes the ECAM logic by introducing a custom PCI ops
implementation that avoids overwriting the DBI base, ensuring compatibility
with vendor drivers that expect a stable DBI address.

The second patch reverts Qualcomm-specific ECAM preparation logic that
is no longer needed due to the updated design.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
Krishna Chaitanya Chundru (2):
      PCI: dwc: Fix ECAM enablement when used with vendor drivers
      PCI: dwc: qcom: Revert "PCI: qcom: Prepare for the DWC ECAM enablement"

 drivers/pci/controller/dwc/pcie-designware-host.c | 28 ++++++++--
 drivers/pci/controller/dwc/pcie-qcom.c            | 68 -----------------------
 2 files changed, 24 insertions(+), 72 deletions(-)
---
base-commit: 9b332cece987ee1790b2ed4c989e28162fa47860
change-id: 20251015-ecam_fix-641d1d5ed71d

Best regards,
-- 
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Re: [PATCH 0/2] PCI: dwc: Fix ECAM enablement when used with vendor drivers
Posted by Bjorn Helgaas 3 months, 3 weeks ago
On Fri, Oct 17, 2025 at 05:10:52PM +0530, Krishna Chaitanya Chundru wrote:
> This series addresses issues with ECAM enablement in the DesignWare PCIe
> host controller when used with vendor drivers that rely on the DBI base
> for internal accesses.
> 
> The first patch fixes the ECAM logic by introducing a custom PCI ops
> implementation that avoids overwriting the DBI base, ensuring compatibility
> with vendor drivers that expect a stable DBI address.
> 
> The second patch reverts Qualcomm-specific ECAM preparation logic that
> is no longer needed due to the updated design.
> 
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> ---
> Krishna Chaitanya Chundru (2):
>       PCI: dwc: Fix ECAM enablement when used with vendor drivers
>       PCI: dwc: qcom: Revert "PCI: qcom: Prepare for the DWC ECAM enablement"
> 
>  drivers/pci/controller/dwc/pcie-designware-host.c | 28 ++++++++--
>  drivers/pci/controller/dwc/pcie-qcom.c            | 68 -----------------------
>  2 files changed, 24 insertions(+), 72 deletions(-)
> ---
> base-commit: 9b332cece987ee1790b2ed4c989e28162fa47860
> change-id: 20251015-ecam_fix-641d1d5ed71d

I hope we can remove the assumption that the root bus is bus 0, but in
the meantime I added these to pci/for-linus so we can build and test
them.

They're after the pci-v6.18-fixes-2 tag I just asked Linus to pull, so
they won't be in v6.18-rc2, but should make it for -rc3.

Bjorn
Re: [PATCH 0/2] PCI: dwc: Fix ECAM enablement when used with vendor drivers
Posted by Krishna Chaitanya Chundru 3 months, 3 weeks ago

On 10/18/2025 3:28 AM, Bjorn Helgaas wrote:
> On Fri, Oct 17, 2025 at 05:10:52PM +0530, Krishna Chaitanya Chundru wrote:
>> This series addresses issues with ECAM enablement in the DesignWare PCIe
>> host controller when used with vendor drivers that rely on the DBI base
>> for internal accesses.
>>
>> The first patch fixes the ECAM logic by introducing a custom PCI ops
>> implementation that avoids overwriting the DBI base, ensuring compatibility
>> with vendor drivers that expect a stable DBI address.
>>
>> The second patch reverts Qualcomm-specific ECAM preparation logic that
>> is no longer needed due to the updated design.
>>
>> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
>> ---
>> Krishna Chaitanya Chundru (2):
>>        PCI: dwc: Fix ECAM enablement when used with vendor drivers
>>        PCI: dwc: qcom: Revert "PCI: qcom: Prepare for the DWC ECAM enablement"
>>
>>   drivers/pci/controller/dwc/pcie-designware-host.c | 28 ++++++++--
>>   drivers/pci/controller/dwc/pcie-qcom.c            | 68 -----------------------
>>   2 files changed, 24 insertions(+), 72 deletions(-)
>> ---
>> base-commit: 9b332cece987ee1790b2ed4c989e28162fa47860
>> change-id: 20251015-ecam_fix-641d1d5ed71d
> 
> I hope we can remove the assumption that the root bus is bus 0, but in
Yes we can remove this assumption.
> the meantime I added these to pci/for-linus so we can build and test
> them.
> 
> They're after the pci-v6.18-fixes-2 tag I just asked Linus to pull, so
> they won't be in v6.18-rc2, but should make it for -rc3.
> 
Thanks Bjorn.

- Krishna Chaitanya.
> Bjorn