This patch series aims to add fan control support to the acer-wmi
driver. The patches are compile-tested only and need to be tested
on real hardware to verify that they actually work.

I CCed three users who requested support for this feature. I would be
very happy if one of you could test those patches and report back.

Changes since v3:
- fix error in WMID_gaming_set_fan_behavior()

Changes since v2:
- get rid of nested bit masks

Changes since v1:
- remove unnecessary blank line

Changes since RFC v2:
- improve error handling when setting fan behavior
- Add Reviewed-by tags
- whitelist PHN16-72

Changes since RFC v1:
- remove duplicate include and replace hwmon_pwm_mode with
  hwmon_pwm_enable in second patch

Armin Wolf (4):
  platform/x86: acer-wmi: Fix setting of fan behavior
  platform/x86: acer-wmi: Add fan control support
  platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
  platform/x86: acer-wmi: Add support for PHN16-72

 drivers/platform/x86/acer-wmi.c | 292 +++++++++++++++++++++++++++++---
 1 file changed, 269 insertions(+), 23 deletions(-)

-- 
2.39.5

On Thu, 16 Oct 2025 20:00:04 +0200, Armin Wolf wrote:

> This patch series aims to add fan control support to the acer-wmi
> driver. The patches are compile-tested only and need to be tested
> on real hardware to verify that they actually work.
> 
> I CCed three users who requested support for this feature. I would be
> very happy if one of you could test those patches and report back.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/4] platform/x86: acer-wmi: Fix setting of fan behavior
      commit: d8e8362b09d31b0a343c0414015d93fbb250d57d
[2/4] platform/x86: acer-wmi: Add fan control support
      commit: 0cc5153f133919bf1e41f3d4c176839aa846d1e0
[3/4] platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
      commit: d727823c134a79f28f16543aec4dced646a1f793
[4/4] platform/x86: acer-wmi: Add support for PHN16-72
      commit: 45cf02f298f33e1c582f77c08bf6d61daf163f27

--
 i.

On Friday, October 17, 2025 1:00 AM Armin Wolf wrote:
> This patch series aims to add fan control support to the acer-wmi
> driver. The patches are compile-tested only and need to be tested
> on real hardware to verify that they actually work.
> 
> I CCed three users who requested support for this feature. I would be
> very happy if one of you could test those patches and report back.
> 
> Changes since v3:
> - fix error in WMID_gaming_set_fan_behavior()
> 
> Changes since v2:
> - get rid of nested bit masks
> 
> Changes since v1:
> - remove unnecessary blank line
> 
> Changes since RFC v2:
> - improve error handling when setting fan behavior
> - Add Reviewed-by tags
> - whitelist PHN16-72
> 
> Changes since RFC v1:
> - remove duplicate include and replace hwmon_pwm_mode with
>   hwmon_pwm_enable in second patch
> 
> Armin Wolf (4):
>   platform/x86: acer-wmi: Fix setting of fan behavior
>   platform/x86: acer-wmi: Add fan control support
>   platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>   platform/x86: acer-wmi: Add support for PHN16-72
> 
>  drivers/platform/x86/acer-wmi.c | 292 +++++++++++++++++++++++++++++---
>  1 file changed, 269 insertions(+), 23 deletions(-)
Hello,

I've tested your patch, had a weird thing where i need to reboot to windows 
first to make fan control works again, but it all works well now, both CPU and 
GPU fan control works just fine.

Thanks,
Fa-Iz Faadhillah Ibrahim

Am 17.10.25 um 16:42 schrieb Fa-Iz Faadhillah Ibrahim:

> On Friday, October 17, 2025 1:00 AM Armin Wolf wrote:
>> This patch series aims to add fan control support to the acer-wmi
>> driver. The patches are compile-tested only and need to be tested
>> on real hardware to verify that they actually work.
>>
>> I CCed three users who requested support for this feature. I would be
>> very happy if one of you could test those patches and report back.
>>
>> Changes since v3:
>> - fix error in WMID_gaming_set_fan_behavior()
>>
>> Changes since v2:
>> - get rid of nested bit masks
>>
>> Changes since v1:
>> - remove unnecessary blank line
>>
>> Changes since RFC v2:
>> - improve error handling when setting fan behavior
>> - Add Reviewed-by tags
>> - whitelist PHN16-72
>>
>> Changes since RFC v1:
>> - remove duplicate include and replace hwmon_pwm_mode with
>>    hwmon_pwm_enable in second patch
>>
>> Armin Wolf (4):
>>    platform/x86: acer-wmi: Fix setting of fan behavior
>>    platform/x86: acer-wmi: Add fan control support
>>    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>>    platform/x86: acer-wmi: Add support for PHN16-72
>>
>>   drivers/platform/x86/acer-wmi.c | 292 +++++++++++++++++++++++++++++---
>>   1 file changed, 269 insertions(+), 23 deletions(-)
> Hello,
>
> I've tested your patch, had a weird thing where i need to reboot to windows
> first to make fan control works again, but it all works well now, both CPU and
> GPU fan control works just fine.
>
> Thanks,
> Fa-Iz Faadhillah Ibrahim

Good work, the reason for this fan control glitch could be that the faulty version of the acpi-wmi
driver left the ACPI firmware interface in an invalid state.

Ilpo, what do you thing about this series?

Thanks,
Armin Wolf