[PATCH v3 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants.

Vitaly Rodionov posted 11 patches 3 months, 3 weeks ago
There is a newer version of this series
.../bindings/sound/cirrus,cs530x.yaml         |   4 +
sound/soc/codecs/Kconfig                      |  10 +
sound/soc/codecs/Makefile                     |   2 +
sound/soc/codecs/cs530x-i2c.c                 |  24 +-
sound/soc/codecs/cs530x-spi.c                 |  92 ++++
sound/soc/codecs/cs530x.c                     | 516 +++++++++++++++---
sound/soc/codecs/cs530x.h                     | 120 ++--
7 files changed, 634 insertions(+), 134 deletions(-)
create mode 100644 sound/soc/codecs/cs530x-spi.c
[PATCH v3 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants.
Posted by Vitaly Rodionov 3 months, 3 weeks ago
This patch series introduces DAC, CODEC, and SPI control bus support
for Cirrus Logic CS530x variants, along with general code cleanup
and resolution of checkpatch.pl warnings.

Simon Trimmer (4):
  ASoC: cs530x: Correct log message with expected variable
  ASoC: cs530x: Add CODEC and DAC support
  ASoC: cs530x: Check the DEVID matches the devtype
  ASoC: cs530x: Rename i2c related structures

Vitaly Rodionov (7):
  ASoC: cs530x: Update the copyright headers
  ASoC: cs530x: Sort #include directives and tidy up whitespaces
  ASoC: cs530x: Remove unused struct members and constants
  ASoC: cs530x: Correct constant naming
  ASoC: cs530x: Correct MCLK reference frequency values
  ASoC: cs530x: Add SPI bus support for cs530x parts
  dt-bindings: sound: cirrus: cs530x: Add additional cs530x family
    variants

 .../bindings/sound/cirrus,cs530x.yaml         |   4 +
 sound/soc/codecs/Kconfig                      |  10 +
 sound/soc/codecs/Makefile                     |   2 +
 sound/soc/codecs/cs530x-i2c.c                 |  24 +-
 sound/soc/codecs/cs530x-spi.c                 |  92 ++++
 sound/soc/codecs/cs530x.c                     | 516 +++++++++++++++---
 sound/soc/codecs/cs530x.h                     | 120 ++--
 7 files changed, 634 insertions(+), 134 deletions(-)
 create mode 100644 sound/soc/codecs/cs530x-spi.c

-- 
2.43.0
Re: [PATCH v3 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants.
Posted by Krzysztof Kozlowski 3 months, 3 weeks ago
On 16/10/2025 18:58, Vitaly Rodionov wrote:
> This patch series introduces DAC, CODEC, and SPI control bus support
> for Cirrus Logic CS530x variants, along with general code cleanup
> and resolution of checkpatch.pl warnings.
> 
No changelog, so are you sending the same? You ignored some of my
comments, so that makes me thinking.

Please read carefully submitting patches how to version your work.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof