[v1] Add power-controller support for RV1126B

[PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B

Posted by Finley Xiao 3 months, 3 weeks ago

Add the compatible string and power domain IDs for RV1126B SoC.

signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
---
 .../power/rockchip,power-controller.yaml        |  2 ++
 .../dt-bindings/power/rockchip,rv1126b-power.h  | 17 +++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 include/dt-bindings/power/rockchip,rv1126b-power.h

diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
index a884e49c995f..f9db602de258 100644
--- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
+++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
@@ -46,6 +46,7 @@ properties:
       - rockchip,rk3576-power-controller
       - rockchip,rk3588-power-controller
       - rockchip,rv1126-power-controller
+      - rockchip,rv1126b-power-controller
 
   "#power-domain-cells":
     const: 1
@@ -126,6 +127,7 @@ $defs:
           "include/dt-bindings/power/rk3568-power.h"
           "include/dt-bindings/power/rk3588-power.h"
           "include/dt-bindings/power/rockchip,rv1126-power.h"
+          "include/dt-bindings/power/rockchip,rv1126b-power.h"
 
       clocks:
         minItems: 1
diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h
new file mode 100644
index 000000000000..0a418f16e4ea
--- /dev/null
+++ b/include/dt-bindings/power/rockchip,rv1126b-power.h
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
+/*
+ * Copyright (c) 2024 Rockchip Electronics Co., Ltd.
+ * Author: Finley Xiao <finley.xiao@rock-chips.com>
+ */
+
+#ifndef __DT_BINDINGS_POWER_RV1126B_POWER_H__
+#define __DT_BINDINGS_POWER_RV1126B_POWER_H__
+
+/* VD_NPU */
+#define RV1126B_PD_NPU		0
+
+/* VD_LOGIC */
+#define RV1126B_PD_VDO		1
+#define RV1126B_PD_AISP		2
+
+#endif
-- 
2.43.0

Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B

Posted by Krzysztof Kozlowski 3 months, 3 weeks ago

On 16/10/2025 15:41, Finley Xiao wrote:
> Add the compatible string and power domain IDs for RV1126B SoC.

And it is not compatible with RV1126 because?

> 
> signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
>  .../power/rockchip,power-controller.yaml        |  2 ++
>  .../dt-bindings/power/rockchip,rv1126b-power.h  | 17 +++++++++++++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 include/dt-bindings/power/rockchip,rv1126b-power.h
> 
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index a884e49c995f..f9db602de258 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -46,6 +46,7 @@ properties:
>        - rockchip,rk3576-power-controller
>        - rockchip,rk3588-power-controller
>        - rockchip,rv1126-power-controller
> +      - rockchip,rv1126b-power-controller
>  
>    "#power-domain-cells":
>      const: 1
> @@ -126,6 +127,7 @@ $defs:
>            "include/dt-bindings/power/rk3568-power.h"
>            "include/dt-bindings/power/rk3588-power.h"
>            "include/dt-bindings/power/rockchip,rv1126-power.h"
> +          "include/dt-bindings/power/rockchip,rv1126b-power.h"
>  
>        clocks:
>          minItems: 1
> diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h
> new file mode 100644
> index 000000000000..0a418f16e4ea
> --- /dev/null
> +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h

Use rather filename matching compatible fully.

> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */


Odd license. Please use recommended licenses.


Best regards,
Krzysztof

Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B

Posted by Heiko Stübner 3 months, 3 weeks ago

Hi Finley,

Am Donnerstag, 16. Oktober 2025, 15:41:02 Mitteleuropäische Sommerzeit schrieb Finley Xiao:
> Add the compatible string and power domain IDs for RV1126B SoC.
> 
> signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---

[...]

> diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h
> new file mode 100644
> index 000000000000..0a418f16e4ea
> --- /dev/null
> +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
> +/*
> + * Copyright (c) 2024 Rockchip Electronics Co., Ltd.
> + * Author: Finley Xiao <finley.xiao@rock-chips.com>
> + */
> +
> +#ifndef __DT_BINDINGS_POWER_RV1126B_POWER_H__
> +#define __DT_BINDINGS_POWER_RV1126B_POWER_H__
> +
> +/* VD_NPU */
> +#define RV1126B_PD_NPU		0
> +
> +/* VD_LOGIC */
> +#define RV1126B_PD_VDO		1
> +#define RV1126B_PD_AISP		2

is this missing a 2nd "i" ? ... The TRM calls this aiisp (for ai-isp maybe?)

Heiko