Follow-up fix for potential error pointer dereference in propagate_to_outer_instance()

[PATCH bpf 0/1] Follow-up fix for potential error pointer dereference in propagate_to_outer_instance()

Shardul Bankar posted 1 patch 3 months, 3 weeks ago

Download series mbox

kernel/bpf/liveness.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH bpf 0/1] Follow-up fix for potential error pointer dereference in propagate_to_outer_instance()

Posted by Shardul Bankar 3 months, 3 weeks ago

Hi BPF maintainers,

This patch follows up on my previous submission:

  [PATCH v2 bpf] bpf: Fix memory leak in __lookup_instance error path
  Link: https://patchwork.kernel.org/project/netdevbpf/list/?series=1012189&state=*

During the review and CI discussions for that patch, a potential issue was
identified in propagate_to_outer_instance(), where get_outer_instance() may
return an ERR_PTR (e.g. -ENOMEM) that is not currently checked before use.

This patch adds a simple IS_ERR() guard and returns the error code to prevent
dereferencing the error pointer.

Thanks,
Shardul

---

Shardul Bankar (1):
  bpf: liveness: Handle ERR_PTR from get_outer_instance() in
    propagate_to_outer_instance()

 kernel/bpf/liveness.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.34.1