[PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1

Cosmo Chou posted 1 patch 3 months, 3 weeks ago
There is a newer version of this series
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 6 ------
1 file changed, 6 deletions(-)
[PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1
Posted by Cosmo Chou 3 months, 3 weeks ago
Remove the external signal configuration from wdt1 to prevent the
WDTRST1 pin from being asserted during watchdog resets.

Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index 24969c82d05e..abdb1562115a 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -1080,11 +1080,5 @@ pinctrl_gpiov2_unbiased_default: gpiov2 {
 
 &wdt1 {
 	status = "okay";
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_wdtrst1_default>;
 	aspeed,reset-type = "soc";
-	aspeed,external-signal;
-	aspeed,ext-push-pull;
-	aspeed,ext-active-high;
-	aspeed,ext-pulse-duration = <256>;
 };
-- 
2.43.0
Re: [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1
Posted by Andrew Jeffery 3 months, 3 weeks ago
On Thu, 2025-10-16 at 13:27 +0800, Cosmo Chou wrote:
> Remove the external signal configuration from wdt1 to prevent the
> WDTRST1 pin from being asserted during watchdog resets.

Yes, this is certainly the immediate impact of the patch.

But what's the motivation? And if asserting WDTRST1 was the wrong thing
to be doing, why was it done to start with?

Please address both questions in an update to the commit message.

Thanks,

Andrew