[PATCH v3 0/2] selftests/fchmodat2: Error handling and general cleanups

Mark Brown posted 2 patches 3 months, 3 weeks ago
tools/testing/selftests/fchmodat2/fchmodat2_test.c | 166 ++++++++++++++-------
1 file changed, 112 insertions(+), 54 deletions(-)
[PATCH v3 0/2] selftests/fchmodat2: Error handling and general cleanups
Posted by Mark Brown 3 months, 3 weeks ago
I looked at the fchmodat2() tests since I've been experiencing some
random intermittent segfaults with them in my test systems, while doing
so I noticed these two issues.  Unfortunately I didn't figure out the
original yet, unless I managed to fix it unwittingly.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Changes in v3:
- Rebase onto v6.18-rc1.
- Link to v2: https://lore.kernel.org/r/20250812-selftests-fchmodat2-v2-0-f2d5380e94c3@kernel.org

Changes in v2:
- Rebase onto v6.17-rc1.
- Link to v1: https://lore.kernel.org/r/20250714-selftests-fchmodat2-v1-0-b74f3ee0d09c@kernel.org

---
Mark Brown (2):
      selftests/fchmodat2: Clean up temporary files and directories
      selftests/fchmodat2: Use ksft_finished()

 tools/testing/selftests/fchmodat2/fchmodat2_test.c | 166 ++++++++++++++-------
 1 file changed, 112 insertions(+), 54 deletions(-)
---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20250711-selftests-fchmodat2-c30374c376f8

Best regards,
--  
Mark Brown <broonie@kernel.org>
Re: [PATCH v3 0/2] selftests/fchmodat2: Error handling and general cleanups
Posted by Alexey Gladkov 3 months, 3 weeks ago
On Wed, Oct 15, 2025 at 01:36:24PM +0100, Mark Brown wrote:
> I looked at the fchmodat2() tests since I've been experiencing some
> random intermittent segfaults with them in my test systems, while doing
> so I noticed these two issues.  Unfortunately I didn't figure out the
> original yet, unless I managed to fix it unwittingly.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Changes in v3:
> - Rebase onto v6.18-rc1.
> - Link to v2: https://lore.kernel.org/r/20250812-selftests-fchmodat2-v2-0-f2d5380e94c3@kernel.org
> 
> Changes in v2:
> - Rebase onto v6.17-rc1.
> - Link to v1: https://lore.kernel.org/r/20250714-selftests-fchmodat2-v1-0-b74f3ee0d09c@kernel.org
> 
> ---
> Mark Brown (2):
>       selftests/fchmodat2: Clean up temporary files and directories
>       selftests/fchmodat2: Use ksft_finished()
> 
>  tools/testing/selftests/fchmodat2/fchmodat2_test.c | 166 ++++++++++++++-------
>  1 file changed, 112 insertions(+), 54 deletions(-)
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20250711-selftests-fchmodat2-c30374c376f8
> 
> Best regards,
> --  
> Mark Brown <broonie@kernel.org>
> 

It make sense. Thanks!

Acked-by: Alexey Gladkov <legion@kernel.org>

-- 
Rgrds, legion