[PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal

Frank Li posted 11 patches 2 months ago
There is a newer version of this series
[PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal
Posted by Frank Li 2 months ago
Rename touch-thermal0 to touch-0-thermal to fix below CHECK_DTBS warnings:
arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: thermal-zones: 'touch-thermal0', 'touch-thermal1' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts | 4 ++--
 arch/arm/boot/dts/nxp/imx/imx6dl-prtvt7.dts | 4 ++--
 arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts
index dfa8110b1d97b14eae30159acc6daf74ae482eb7..da70908334d71f58aa53b13726a69c1db12ae1b8 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts
@@ -123,7 +123,7 @@ alert {
 			};
 		};
 
-		touch-thermal0 {
+		touch0-thermal {
 			polling-delay = <20000>;
 			polling-delay-passive = <0>;
 			thermal-sensors = <&touch_temp0>;
@@ -137,7 +137,7 @@ alert {
 			};
 		};
 
-		touch-thermal1 {
+		touch1-thermal {
 			polling-delay = <20000>;
 			polling-delay-passive = <0>;
 			thermal-sensors = <&touch_temp1>;
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-prtvt7.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-prtvt7.dts
index 29dc6875ab6680d316bc28619df883ad2411ab28..c9dc48c1f9b1c36e33a55c64b9fa64262f011f8e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-prtvt7.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-prtvt7.dts
@@ -256,7 +256,7 @@ alert {
 			};
 		};
 
-		touch-thermal0 {
+		touch-0-thermal {
 			polling-delay = <20000>;
 			polling-delay-passive = <0>;
 			thermal-sensors = <&touch_temp0>;
@@ -270,7 +270,7 @@ alert {
 			};
 		};
 
-		touch-thermal1 {
+		touch-1-thermal {
 			polling-delay = <20000>;
 			polling-delay-passive = <0>;
 			thermal-sensors = <&touch_temp1>;
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts
index 4875afadb63005d101c4501b70f64761d732b86f..e258e7b3b3fe792d061002a6b70bef4b22c5e89e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts
@@ -84,7 +84,7 @@ alert {
 			};
 		};
 
-		touch-thermal0 {
+		touch-0-thermal {
 			polling-delay = <20000>;
 			polling-delay-passive = <0>;
 			thermal-sensors = <&touch_temp0>;
@@ -98,7 +98,7 @@ alert {
 			};
 		};
 
-		touch-thermal1 {
+		touch-1-thermal {
 			polling-delay = <20000>;
 			polling-delay-passive = <0>;
 			thermal-sensors = <&touch_temp1>;

-- 
2.34.1
Re: [PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal
Posted by Russell King (Oracle) 2 months ago
On Wed, Oct 15, 2025 at 12:44:27PM -0400, Frank Li wrote:
> -		touch-thermal0 {
> +		touch0-thermal {
...
> -		touch-thermal1 {
> +		touch1-thermal {
...
> -		touch-thermal0 {
> +		touch-0-thermal {
...
> -		touch-thermal1 {
> +		touch-1-thermal {
...
> -		touch-thermal0 {
> +		touch-0-thermal {
...
> -		touch-thermal1 {
> +		touch-1-thermal {

Is it touch-N-thermal or touchN-thermal?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal
Posted by Frank Li 2 months ago
On Wed, Oct 15, 2025 at 09:00:15PM +0100, Russell King (Oracle) wrote:
> On Wed, Oct 15, 2025 at 12:44:27PM -0400, Frank Li wrote:
> > -		touch-thermal0 {
> > +		touch0-thermal {
> ...
> > -		touch-thermal1 {
> > +		touch1-thermal {
> ...
> > -		touch-thermal0 {
> > +		touch-0-thermal {
> ...
> > -		touch-thermal1 {
> > +		touch-1-thermal {
> ...
> > -		touch-thermal0 {
> > +		touch-0-thermal {
> ...
> > -		touch-thermal1 {
> > +		touch-1-thermal {
>
> Is it touch-N-thermal or touchN-thermal?

What's difference? I suppose both naming should be okay.

Frank
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal
Posted by Russell King (Oracle) 2 months ago
On Wed, Oct 15, 2025 at 04:34:34PM -0400, Frank Li wrote:
> On Wed, Oct 15, 2025 at 09:00:15PM +0100, Russell King (Oracle) wrote:
> > On Wed, Oct 15, 2025 at 12:44:27PM -0400, Frank Li wrote:
> > > -		touch-thermal0 {
> > > +		touch0-thermal {
> > ...
> > > -		touch-thermal1 {
> > > +		touch1-thermal {
> > ...
> > > -		touch-thermal0 {
> > > +		touch-0-thermal {
> > ...
> > > -		touch-thermal1 {
> > > +		touch-1-thermal {
> > ...
> > > -		touch-thermal0 {
> > > +		touch-0-thermal {
> > ...
> > > -		touch-thermal1 {
> > > +		touch-1-thermal {
> >
> > Is it touch-N-thermal or touchN-thermal?
> 
> What's difference? I suppose both naming should be okay.

Surely you'd want to be consistent with the node naming? Otherwise
state in the commit message why you're using two different names
where the originals had the same name.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!