[PATCH] docs: admin-guide: update tiny script for number of taint flags

Randy Dunlap posted 1 patch 2 months ago
Documentation/admin-guide/tainted-kernels.rst |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] docs: admin-guide: update tiny script for number of taint flags
Posted by Randy Dunlap 2 months ago
Account for 2 new taint flags being added by increasing the number of
bits handled by the tiny show-tainted-flags example script.

Fixes: 8eea4e744758 ("taint: Add TAINT_FWCTL")
Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: David Gow <davidgow@google.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
 Documentation/admin-guide/tainted-kernels.rst |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20251013.orig/Documentation/admin-guide/tainted-kernels.rst
+++ linux-next-20251013/Documentation/admin-guide/tainted-kernels.rst
@@ -74,7 +74,7 @@ a particular type of taint. It's best to
 script, but if you need something quick you can use this shell command to check
 which bits are set::
 
-	$ for i in $(seq 18); do echo $(($i-1)) $(($(cat /proc/sys/kernel/tainted)>>($i-1)&1));done
+	$ for i in $(seq 20); do echo $(($i-1)) $(($(cat /proc/sys/kernel/tainted)>>($i-1)&1));done
 
 Table for decoding tainted state
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags
Posted by Jason Gunthorpe 2 months ago
On Mon, Oct 13, 2025 at 08:15:38PM -0700, Randy Dunlap wrote:
> Account for 2 new taint flags being added by increasing the number of
> bits handled by the tiny show-tainted-flags example script.

Maybe add a comment near the array about this :\

Jason
Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags
Posted by David Gow 2 months ago
On Tue, 14 Oct 2025 at 11:15, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Account for 2 new taint flags being added by increasing the number of
> bits handled by the tiny show-tainted-flags example script.
>
> Fixes: 8eea4e744758 ("taint: Add TAINT_FWCTL")
> Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: David Gow <davidgow@google.com>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---

Thanks for catching this!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David