[PATCH v2 0/5] Microchip mpfs/pic64gx pinctrl

Conor Dooley posted 5 patches 2 months ago
There is a newer version of this series
.../microchip,mpfs-pinctrl-iomux0.yaml        |  88 +++++
.../microchip,pic64gx-pinctrl-gpio2.yaml      |  73 ++++
.../microchip,mpfs-mss-top-sysreg.yaml        |  13 +-
MAINTAINERS                                   |   4 +
drivers/pinctrl/Kconfig                       |  14 +
drivers/pinctrl/Makefile                      |   2 +
drivers/pinctrl/pinctrl-mpfs-iomux0.c         | 278 ++++++++++++++
drivers/pinctrl/pinctrl-pic64gx-gpio2.c       | 357 ++++++++++++++++++
8 files changed, 828 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,mpfs-pinctrl-iomux0.yaml
create mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,pic64gx-pinctrl-gpio2.yaml
create mode 100644 drivers/pinctrl/pinctrl-mpfs-iomux0.c
create mode 100644 drivers/pinctrl/pinctrl-pic64gx-gpio2.c
[PATCH v2 0/5] Microchip mpfs/pic64gx pinctrl
Posted by Conor Dooley 2 months ago
From: Conor Dooley <conor.dooley@microchip.com>

Hey folks,

Following from my RFC recently [0] I've got a v2 here that's implemented
the change from using the pinmux property to using functions and groups
that you asked for Linus.

There's some use of macros to cut down on redefining groups etc multiple
times that I figured would help me avoid ADHD mistakes, but I can just
get rid of that if you hate it.

I'll follow this with a reply to the gpio2 driver with some comments
about the noun use that we discussed on Monday Linus.

I'm not expecting this version to get applied, and it doesn't apply
right now due to a missing dep that is the first patch in [1]. I maintain
that binding directory though, so it's not as if we wouldn't be able to
trivially figure out how to deal with that anyway.

Cheers,
Conor.

0 - https://lore.kernel.org/all/20250926-manpower-glacial-e9756c82b427@spud/
1 - https://lore.kernel.org/all/20251013-posting-alright-8f945a4bebfd@spud/

CC: Linus Walleij <linus.walleij@linaro.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: linux-kernel@vger.kernel.org
CC: linux-gpio@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: Valentina.FernandezAlanis@microchip.com

Conor Dooley (5):
  dt-bindings: pinctrl: document pic64gx "gpio2" pinmux
  pinctrl: add pic64gx "gpio2" pinmux driver
  dt-bindings: pinctrl: document polarfire soc iomux0 pinmux
  pinctrl: add polarfire soc iomux0 pinmux driver
  MAINTAINERS: add Microchip RISC-V pinctrl drivers/bindings to entry

 .../microchip,mpfs-pinctrl-iomux0.yaml        |  88 +++++
 .../microchip,pic64gx-pinctrl-gpio2.yaml      |  73 ++++
 .../microchip,mpfs-mss-top-sysreg.yaml        |  13 +-
 MAINTAINERS                                   |   4 +
 drivers/pinctrl/Kconfig                       |  14 +
 drivers/pinctrl/Makefile                      |   2 +
 drivers/pinctrl/pinctrl-mpfs-iomux0.c         | 278 ++++++++++++++
 drivers/pinctrl/pinctrl-pic64gx-gpio2.c       | 357 ++++++++++++++++++
 8 files changed, 828 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,mpfs-pinctrl-iomux0.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,pic64gx-pinctrl-gpio2.yaml
 create mode 100644 drivers/pinctrl/pinctrl-mpfs-iomux0.c
 create mode 100644 drivers/pinctrl/pinctrl-pic64gx-gpio2.c

-- 
2.51.0
Re: [PATCH v2 0/5] Microchip mpfs/pic64gx pinctrl
Posted by Linus Walleij 1 month, 4 weeks ago
On Tue, Oct 14, 2025 at 4:36 PM Conor Dooley <conor@kernel.org> wrote:

> From: Conor Dooley <conor.dooley@microchip.com>

> Following from my RFC recently [0] I've got a v2 here that's implemented
> the change from using the pinmux property to using functions and groups
> that you asked for Linus.

Overall I'm very happy with what I see, I see there are some comments
and my only comment would be to add

depends on ARCH_MICROCHIP || COMPILE_TEST

on the drivers so they get some proper compile testing, and I expect
we can apply v3.

Yours,
Linus Walleij
Re: [PATCH v2 0/5] Microchip mpfs/pic64gx pinctrl
Posted by Conor Dooley 1 month, 4 weeks ago
On Mon, Oct 20, 2025 at 11:05:53PM +0200, Linus Walleij wrote:
> On Tue, Oct 14, 2025 at 4:36 PM Conor Dooley <conor@kernel.org> wrote:
> 
> > From: Conor Dooley <conor.dooley@microchip.com>
> 
> > Following from my RFC recently [0] I've got a v2 here that's implemented
> > the change from using the pinmux property to using functions and groups
> > that you asked for Linus.
> 
> Overall I'm very happy with what I see, I see there are some comments
> and my only comment would be to add
> 
> depends on ARCH_MICROCHIP || COMPILE_TEST
> 
> on the drivers so they get some proper compile testing, and I expect
> we can apply v3.

Oh, that's a silly one to forget about. I'll do that and just delete the
TODO line that I had in there, since you've not objected to the macro
use.

Thanks,
Conor.