Fix many oddities inside the MACB driver. They accumulated in my
work-in-progress branch while working on MACB/GEM EyeQ5 support.
Part of this series has been seen on the lkml in March then June.
See below for a semblance of a changelog.
The initial goal was to post them alongside EyeQ5 support, but that
makes for too big of a series. It'll come afterwards, with new
features (interrupt coalescing, ethtool .set_channels() and XDP mostly).
Thanks,
Have a nice day,
Théo
[0]: https://lore.kernel.org/lkml/20250627-macb-v2-0-ff8207d0bb77@bootlin.com/
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
Changes since June V2:
- Six patches are straight copies:
dt-bindings: net: cdns,macb: sort compatibles
net: macb: use BIT() macro for capability definitions
net: macb: Remove local variables clk_init and init in macb_probe()
net: macb: drop macb_config NULL checking
net: macb: introduce DMA descriptor helpers (is 64bit? is PTP?)
net: macb: sort #includes
- The "introduce DMA descriptor helpers" patch was split in two:
net: macb: simplify macb_dma_desc_get_size()
net: macb: introduce DMA descriptor helpers (is 64bit? is PTP?)
- Three patches come from Sean's feedback:
net: macb: remove gap in MACB_CAPS_* flags
net: macb: simplify macb_adj_dma_desc_idx()
net: macb: move bp->hw_dma_cap flags to bp->caps
- Take 1x Reviewed-by: Krzysztof Kozlowski
- Take 3x Reviewed-by: Sean Anderson
- Link: https://lore.kernel.org/lkml/20250627-macb-v2-0-ff8207d0bb77@bootlin.com/
---
Théo Lebrun (15):
dt-bindings: net: cdns,macb: sort compatibles
net: macb: use BIT() macro for capability definitions
net: macb: remove gap in MACB_CAPS_* flags
net: macb: Remove local variables clk_init and init in macb_probe()
net: macb: drop macb_config NULL checking
net: macb: simplify macb_dma_desc_get_size()
net: macb: simplify macb_adj_dma_desc_idx()
net: macb: move bp->hw_dma_cap flags to bp->caps
net: macb: introduce DMA descriptor helpers (is 64bit? is PTP?)
net: macb: remove bp->queue_mask
net: macb: replace min() with umin() calls
net: macb: drop `entry` local variable in macb_tx_map()
net: macb: drop `count` local variable in macb_tx_map()
net: macb: apply reverse christmas tree in macb_tx_map()
net: macb: sort #includes
.../devicetree/bindings/net/cdns,macb.yaml | 8 +-
drivers/net/ethernet/cadence/macb.h | 71 +++---
drivers/net/ethernet/cadence/macb_main.c | 257 +++++++++------------
drivers/net/ethernet/cadence/macb_ptp.c | 16 +-
4 files changed, 151 insertions(+), 201 deletions(-)
---
base-commit: 6a445aebc188bdb9a82519c5fe64eb92b1d025b9
change-id: 20251014-macb-cleanup-2ce7b8b1ec56
Best regards,
--
Théo Lebrun <theo.lebrun@bootlin.com>